yimingpeng commented on code in PR #55670:
URL: https://github.com/apache/airflow/pull/55670#discussion_r2471969088
##########
airflow-core/src/airflow/api_fastapi/core_api/services/ui/grid.py:
##########
@@ -103,13 +103,28 @@ def _find_aggregates(
for child in get_task_group_children_getter()(node):
for child_node in _find_aggregates(node=child, parent_node=node,
ti_details=ti_details):
if child_node["parent_id"] == node_id:
- children.append(
- {
- "state": child_node["state"],
- "start_date": child_node["min_start_date"],
- "end_date": child_node["max_end_date"],
- }
- )
+ # If the child has child_states (like mapped tasks),
expand them
+ # to count all individual task instances rather than just
one child node
+ if child_node.get("child_states"):
+ # For each state in child_states, add that many
entries to children
+ for state, count in child_node["child_states"].items():
+ for _ in range(count):
+ children.append(
+ {
+ "state": state if state != "None" else
None,
+ "start_date":
child_node["min_start_date"],
+ "end_date": child_node["max_end_date"],
Review Comment:
Thanks for review @pierrejeambrun , I sorta changed the approach to pass
thru task instance details (`mapped_details`) rather than aggregate them. I
think this addresses your comments, and aggregation can happen only at parent
task group level with the details passed through, does this sound right to you?
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
