ashb commented on code in PR #57494:
URL: https://github.com/apache/airflow/pull/57494#discussion_r2474211534
##########
task-sdk/src/airflow/sdk/execution_time/hitl.py:
##########
@@ -48,7 +48,10 @@ def upsert_hitl_detail(
) -> None:
from airflow.sdk.execution_time.task_runner import SUPERVISOR_COMMS
- SUPERVISOR_COMMS.send(
+ # Capture the response to consume it from the socket
+ # The supervisor sends a response back, and we need to read it
+ # to prevent it from being consumed by the next SUPERVISOR_COMMS.send()
call
+ _response = SUPERVISOR_COMMS.send(
Review Comment:
Before `send()` was added on SupervisorComms, this was two methods, send and
get_response, and in that world we each caller had to call get_response. But
since it was refactored and `send()` now does that itself and returns it the
"consume a response" is always done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
