dheerajturaga commented on code in PR #57459:
URL: https://github.com/apache/airflow/pull/57459#discussion_r2474282757
##########
airflow-core/src/airflow/jobs/dag_processor_job_runner.py:
##########
@@ -56,6 +57,9 @@ def __init__(
)
def _execute(self) -> int | None:
+ # Mark this as a server context for secrets backend detection
+ os.environ["_AIRFLOW_PROCESS_CONTEXT"] = "server"
+
Review Comment:
@kaxil even though dag-processor is "client-side":
1. Only the child parser subprocess has SUPERVISOR_COMMS (is truly
client-side)
2. The parent manager runs as a Job with database access (looks
server-side)
I believe the fix I made (_AIRFLOW_PROCESS_CONTEXT=server) is correct
because:
- Manager is server-side infrastructure
- It has database access via Job
- It's analogous to Scheduler (which sets server)
- GitHook initialization happens in manager, not child
What do you think? the git dag bundles feature is broken out of the box
without this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
