Easonliuuuuu opened a new pull request, #57530:
URL: https://github.com/apache/airflow/pull/57530

   ## Summary
   When `email_on_failure=True`, tasks were failing with an `UndefinedError: 
... has no attribute 'mark_success_url'`. This happened because the 
`RuntimeTaskInstance` object, which is used in this context, does not have the 
`mark_success_url` attribute, but the HTML email templates 
(`default_html_content` and `default_html_content_err`) were trying to access 
it.
   
   This PR resolves the error by removing the "Mark Success" link from both 
templates in `airflow/models/taskinstance.py`, as recommended in the issue for 
the Airflow 3.1+ fix.
   
   closes: #57507 
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to