ephraimbuddy commented on code in PR #56422:
URL: https://github.com/apache/airflow/pull/56422#discussion_r2476728037
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -414,7 +414,14 @@ def write_dag(
serialized_dag_hash = session.scalars(
select(cls.dag_hash).where(cls.dag_id ==
dag.dag_id).order_by(cls.created_at.desc())
).first()
- dag_version = DagVersion.get_latest_version(dag.dag_id,
session=session)
+ dag_version = session.scalar(
+ select(DagVersion)
+ .where(DagVersion.dag_id == dag.dag_id)
+ .options(joinedload(DagVersion.task_instances))
+ .options(joinedload(DagVersion.serialized_dag))
Review Comment:
Yeah, though not fully wrong. Line 438 was supposed to use the serdag.
`latest_ser_dag = dag_version.serialized_dag`
but omitted. I will open a PR to address it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
