jason810496 commented on code in PR #57571:
URL: https://github.com/apache/airflow/pull/57571#discussion_r2478738187
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -868,6 +868,15 @@ def _transform_ti_states(states: list[str] | None) ->
list[TaskInstanceState | N
filter_param_factory(TaskInstance.queue, list[str],
FilterOptionEnum.ANY_EQUAL, default_factory=list)
),
]
+QueryTIPoolPatternSearch = Annotated[
+ _SearchParam,
+ Depends(search_param_factory(TaskInstance.pool, "pool_pattern")),
Review Comment:
```suggestion
Depends(search_param_factory(TaskInstance.pool, "pool_name_pattern")),
```
Since we have already used `pool_name_pattern` for other endpoint, would it
be better to use `pool_name_pattern` instead of `pool_pattern` ?
https://github.com/apache/airflow/blob/16c544079dab9cd5967951b4dc8076ade19f0ca8/airflow-core/src/airflow/api_fastapi/common/parameters.py#L964-L96
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -868,6 +868,15 @@ def _transform_ti_states(states: list[str] | None) ->
list[TaskInstanceState | N
filter_param_factory(TaskInstance.queue, list[str],
FilterOptionEnum.ANY_EQUAL, default_factory=list)
),
]
+QueryTIPoolPatternSearch = Annotated[
+ _SearchParam,
+ Depends(search_param_factory(TaskInstance.pool, "pool_pattern")),
+]
+
+QueryTIQueuePatternSearch = Annotated[
+ _SearchParam,
+ Depends(search_param_factory(TaskInstance.queue, "queue_pattern")),
Review Comment:
```suggestion
Depends(search_param_factory(TaskInstance.queue, "queue_name_pattern")),
```
If so, we might need to name as `queue_name_pattern` to follow the same
naming convention.
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -868,6 +868,15 @@ def _transform_ti_states(states: list[str] | None) ->
list[TaskInstanceState | N
filter_param_factory(TaskInstance.queue, list[str],
FilterOptionEnum.ANY_EQUAL, default_factory=list)
),
]
+QueryTIPoolPatternSearch = Annotated[
+ _SearchParam,
+ Depends(search_param_factory(TaskInstance.pool, "pool_pattern")),
+]
+
+QueryTIQueuePatternSearch = Annotated[
+ _SearchParam,
+ Depends(search_param_factory(TaskInstance.queue, "queue_pattern")),
Review Comment:
```suggestion
Depends(search_param_factory(TaskInstance.queue, "queue_name_pattern")),
```
If so, we might need to name it as `queue_name_pattern` to follow the same
naming convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
