kaxil commented on code in PR #57450:
URL: https://github.com/apache/airflow/pull/57450#discussion_r2478920068
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -607,7 +621,16 @@ def get_list_dag_runs_batch(
{"dag_run_id": "run_id"},
).set_value([body.order_by] if body.order_by else None)
- base_query = select(DagRun).options(joinedload(DagRun.dag_model))
+ base_query = select(DagRun).options(
+ joinedload(DagRun.dag_model),
+ selectinload(DagRun.task_instances)
+ .joinedload(TaskInstance.dag_version)
+ .joinedload(DagVersion.bundle),
+ selectinload(DagRun.task_instances_histories)
+ .joinedload(TaskInstanceHistory.dag_version)
+ .joinedload(DagVersion.bundle),
+ joinedload(DagRun.dag_run_note),
+ )
Review Comment:
Yiked -- @ephraimbuddy @dstandish Can you both review this too please
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -607,7 +621,16 @@ def get_list_dag_runs_batch(
{"dag_run_id": "run_id"},
).set_value([body.order_by] if body.order_by else None)
- base_query = select(DagRun).options(joinedload(DagRun.dag_model))
+ base_query = select(DagRun).options(
+ joinedload(DagRun.dag_model),
+ selectinload(DagRun.task_instances)
+ .joinedload(TaskInstance.dag_version)
+ .joinedload(DagVersion.bundle),
+ selectinload(DagRun.task_instances_histories)
+ .joinedload(TaskInstanceHistory.dag_version)
+ .joinedload(DagVersion.bundle),
+ joinedload(DagRun.dag_run_note),
+ )
Review Comment:
Yikes -- @ephraimbuddy @dstandish Can you both review this too please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
