jscheffl commented on code in PR #57531:
URL: https://github.com/apache/airflow/pull/57531#discussion_r2479343232
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -910,7 +910,9 @@ async def delete_pod(self, name: str, namespace: str):
if str(e.status) != "404":
raise
- async def read_logs(self, name: str, namespace: str):
+ async def read_logs(
+ self, name: str, namespace: str, container_name: str | None = None,
since_seconds: int | None = None
+ ):
Review Comment:
As this method now returns logs, can you please add a typo annotation for
the result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
