ephraimbuddy commented on code in PR #54505:
URL: https://github.com/apache/airflow/pull/54505#discussion_r2480363056
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -81,13 +76,18 @@
PodNotFoundException,
PodPhase,
)
-from airflow.providers.cncf.kubernetes.version_compat import AIRFLOW_V_3_1_PLUS
+from airflow.providers.cncf.kubernetes.version_compat import (
+ AIRFLOW_V_3_1_PLUS,
+ AirflowSkipException,
+ TaskDeferred,
+)
from airflow.providers.common.compat.sdk import XCOM_RETURN_KEY
if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import BaseOperator
else:
from airflow.models import BaseOperator
+from airflow.exceptions import AirflowException
Review Comment:
No. It won't issue deprecated import warning. I didn't deprecate
AirflowException. Instead I imported it into core exceptions from task-sdk
exception. it think it's a better way than deprecating or duplicating since
duplicating would mean rewriting in so many places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
