vincbeck commented on code in PR #57563:
URL: https://github.com/apache/airflow/pull/57563#discussion_r2481322527
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -569,7 +574,7 @@ def try_adopt_task_instances(self, tis:
Sequence[TaskInstance]) -> Sequence[Task
tis_to_flush_by_key = {ti.key: ti for ti in tis if
ti.queued_by_job_id}
kube_client: client.CoreV1Api = self.kube_client
for scheduler_job_id in scheduler_job_ids:
- scheduler_job_id =
self._make_safe_label_value(str(scheduler_job_id))
+ scheduler_job_id = cast("int",
self._make_safe_label_value(str(scheduler_job_id)))
Review Comment:
Yeah but we need to understand what is going on. We cannot just cast the
string in int because mypy says so. @o-nikolas (you're the last one who
modified this line, sorry haha). Do you know why we pass `scheduler_job_id`
(which is an int) to `_make_safe_label_value` which seems to be a function to
secure a string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
