cmbilly8 commented on PR #57680:
URL: https://github.com/apache/airflow/pull/57680#issuecomment-3480312722

   > Overall looks good. Small nit, I think we just need to output one not 
found message in UI is enough.
   
   Just updated to conditionally render the heading only if the result count is 
> 0 so that we aren't telling the user twice that there are no results:
   
   Dag Runs
   <table> <tr> <td align="center"><b>Results &gt; 0</b><br> <img width="600" 
alt="Dag Runs with results" 
src="https://github.com/user-attachments/assets/3b5adc11-f6c8-4df0-b152-02fd3a60c512";
 /> </td> <td align="center"><b>No results</b><br> <img width="600" alt="Dag 
Runs no results" 
src="https://github.com/user-attachments/assets/922f48ee-5b13-4cfc-9ef2-dcabe13239d6";
 /> </td> </tr> </table>
   Task Instances
   <table> <tr> <td align="center"><b>Results &gt; 0</b><br> <img width="600" 
alt="Task Instances with results" 
src="https://github.com/user-attachments/assets/f444f715-41ed-493d-99c7-84b2f23f9baa";
 /> </td> <td align="center"><b>No results</b><br> <img width="600" alt="Task 
Instances no results" 
src="https://github.com/user-attachments/assets/97509a40-6d37-4013-aeae-981b1bd1378d";
 /> </td> </tr> </table>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to