uranusjr commented on code in PR #54421:
URL: https://github.com/apache/airflow/pull/54421#discussion_r2488996754
##########
task-sdk/src/airflow/sdk/definitions/context.py:
##########
@@ -37,31 +37,31 @@
)
-class Context(TypedDict, total=False):
Review Comment:
If I recall correctly (not sure), `total=False` only affects if everything
declared are in the dict; it does not affect if you can put other things in
(type checker always flags, runtime always allows). So we don’t need this if we
mark all the optional keys with NotRequired (do we?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
