potiuk commented on code in PR #57796:
URL: https://github.com/apache/airflow/pull/57796#discussion_r2490495515
##########
dev/README_RELEASE_PROVIDERS.md:
##########
@@ -696,15 +696,15 @@ subject:
```shell script
cat <<EOF
-$([ $VOTE_DURATION_IN_HOURS -ge 72 ] && echo "[VOTE]" || echo "[ACCELERATED
VOTE]") Airflow Providers prepared on $(LANG=en_US.UTF-8 TZ=UTC date "+%B %d,
%Y")
+$([ $VOTE_DURATION_IN_HOURS -ge 72 ] && echo "[VOTE]" || echo "[ACCELERATED
VOTE]") Airflow Providers, package date ${PACKAGE_DATE}")
Review Comment:
I actually made a bit deeper updates @eladkal, @amoghrajesh -> please take
another look
1) I replaced PACKAGE_DATE with RELEASE_DATE everywhere - it's much more
reasonable name than PACKAGE_DATE
2) I use it everywhere in the scripts, check_files.py and instructions - and
instructions are there to set it when needeed - either by release manager, when
they prepare the release or to take it from release email when you verify the
release
3) Instead of falling back to default YYYY-MM-DD in Python, the RELEASE_DATE
env variable is expected to be set in the check_files.py and in tag_providers
command now. They are now **required** paameters for those commands - and will
fail when not set manually or via ENVVAR.
4) I remove DAYS_BACK - rather than calculating the release date from days
back, the release manager when releasing has to explicitly state RELEASE_DATE
variable to indicate which release they are releasing.
I did as much testing of it as possible, but likely we will find some small
things to fix when we release next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
