jason810496 opened a new pull request, #57814:
URL: https://github.com/apache/airflow/pull/57814
- Create new auth_manager.py module in common with AuthManagerDep
- Update security.py to use AuthManagerDep instead of
request.app.state.auth_manager
- Update auth.py routes to use AuthManagerDep
- Remove Request parameter where no longer needed
- Follow the same dependency injection pattern as DagBag
Add unit tests for auth_manager dependency injection
- Create test_auth_manager.py to test the new dependency
- Verify auth_manager_from_app correctly retrieves from app.state
- Test integration with existing test client fixture
Fix linting issues with ruff
- Move BaseAuthManager import out of TYPE_CHECKING block
- Fix import ordering in security.py
- Remove unused pytest import from test
- Remove trailing whitespace
- Format code with ruff format
Move auth_manager dependency to security.py module
- Move auth_manager_from_app and AuthManagerDep from common/auth_manager.py
to core_api/security.py
- Update import in routes/public/auth.py to use security module
- Move tests from common/test_auth_manager.py to core_api/test_security.py
- Delete now-unused common/auth_manager.py and common/test_auth_manager.py
- Import BaseAuthManager directly in security.py (not in TYPE_CHECKING)
(cherry picked from commit 1242e07c0fe4577059c841c97ba09063ec391247)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
