HaJunYoo commented on code in PR #57713:
URL: https://github.com/apache/airflow/pull/57713#discussion_r2488930356
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/gcs_to_s3.py:
##########
@@ -124,6 +128,10 @@ def __init__(
self.dest_s3_extra_args = dest_s3_extra_args or {}
self.s3_acl_policy = s3_acl_policy
self.keep_directory_structure = keep_directory_structure
+ self.flatten_structure = flatten_structure
+
+ if self.flatten_structure and self.keep_directory_structure:
+ self.log.warning("flatten_structure=True overrides
keep_directory_structure=True")
Review Comment:
> Good for safeguarding here. How about adding this precedence note to the
top-level docstring so users immediately understand that flatten_structure=True
overrides the directory flag?
I've addressed your suggestion (adding note) in this commit
[96a2a36](https://github.com/apache/airflow/commit/96a2a360906db8297eba377efec02ff36fecfac5)
and
[5fd0d92](https://github.com/apache/airflow/pull/57713/commits/5fd0d922773a312b954a8eb83d8ed6c2e821d3e9)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
