amoghrajesh commented on code in PR #57354:
URL: https://github.com/apache/airflow/pull/57354#discussion_r2493650718
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -1188,99 +1188,78 @@ def _run_task_state_change_callbacks(
log.exception("Failed to run task callback", kind=kind, index=i,
callback=callback)
-def _get_email_subject_content(
- *,
- task_instance: RuntimeTaskInstance,
- exception: BaseException | str | None,
+def _send_error_email_notification(
+ task: BaseOperator | MappedOperator,
+ ti: RuntimeTaskInstance,
+ context: Context,
+ error: BaseException | str | None,
log: Logger,
-) -> tuple[str, str, str]:
- """
- Get the email subject content for exceptions.
-
- :param task_instance: the task instance
- :param exception: the exception sent in the email
- :param task:
-
- :meta private:
- """
- from airflow.sdk.definitions._internal.templater import
SandboxedEnvironment
- from airflow.sdk.definitions.context import Context,
render_template_to_string
-
- exception_html = str(exception).replace("\n", "<br>")
-
- default_subject = "Airflow alert: {{ti}}"
- # For reporting purposes, we report based on 1-indexed,
- # not 0-indexed lists (i.e. Try 1 instead of
- # Try 0 for the first attempt).
- default_html_content = (
- "Try {{try_number}} out of {{max_tries + 1}}<br>"
- "Exception:<br>{{exception_html}}<br>"
- 'Log: <a href="{{ti.log_url}}">Link</a><br>'
- "Host: {{ti.hostname}}<br>"
- 'Mark success: <a href="{{ti.mark_success_url}}">Link</a><br>'
- )
+) -> None:
+ """Send email notification for task errors using SmtpNotifier."""
+ try:
+ from airflow.providers.smtp.notifications.smtp import SmtpNotifier
+ except ImportError:
+ log.error(
+ "Failed to send task failure or retry email notification: "
+ "`apache-airflow-providers-smtp` is not installed. "
+ "Install this provider to enable email notifications."
+ )
+ return
Review Comment:
Yeah right now its fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
