amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r349927589
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -721,25 +721,14 @@ def _process_task_instances(self, dag,
task_instances_list, session=None):
if run.state == State.RUNNING:
make_transient(run)
active_dag_runs.append(run)
-
- for run in active_dag_runs:
- self.log.debug("Examining active DAG run: %s", run)
- tis = run.get_task_instances(state=SCHEDULEABLE_STATES)
-
- # this loop is quite slow as it uses are_dependencies_met for
- # every task (in ti.is_runnable). This is also called in
- # update_state above which has already checked these tasks
- for ti in tis:
- task = dag.get_task(ti.task_id)
-
- # fixme: ti.task is transient but needs to be set
- ti.task = task
-
- if ti.are_dependencies_met(
- dep_context=DepContext(flag_upstream_failed=True),
- session=session):
+ self.log.debug("Examining active DAG run: %s", run)
+ for ti in run.ready_tis:
Review comment:
yes :)
However just few tests use it for the state and it is kind of an easy change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
