jscheffl commented on PR #57642:
URL: https://github.com/apache/airflow/pull/57642#issuecomment-3493348436

   > > Whereas I would like to have feedback as well as in 
airflow-core/src/airflow/configuration.py:2108 actually we changed in the past 
to always generate a FERNET_KEY even if none is provided, so could we erase-out 
some complexity as we assume durnog start there will be always one FERNET_KEY 
being around?
   > 
   > I think that one is needed. When you want to do `uv run airflow` (clean 
installation), the fernet key should be generated.
   
   I was referring to that in crypto.py there is a `NullFernet` (See 
https://github.com/apache/airflow/pull/57642/files#diff-ea01949f936d456948b59bea1b89f14e28c7ecfc952063998ca4d0176c761d4fR44)
 which implements the protocol but is a NOP crypt. It is selected if no 
FERNET_KEY is configured (see 
https://github.com/apache/airflow/pull/57642/files#diff-ea01949f936d456948b59bea1b89f14e28c7ecfc952063998ca4d0176c761d4fR111)...
 but if configuration.py:2108 always generates one if not configured we can 
potentially consider dropping the NullFernet?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to