1fanwang commented on PR #56272: URL: https://github.com/apache/airflow/pull/56272#issuecomment-3494063607
> > Ah, small nit to make CI Green - Pytests need to be adjusted it seems. Let me/us know if you have a hard time reproducing, all documented in development guides how to run tests locally. > > Thanks! I just got a chance to repro this locally, I must have missed this between edits. Fixing it now: > > ``` > root@06119dee0475:/opt/airflow# pytest airflow-core/tests/unit/jobs/test_scheduler_job.py > > FAILED airflow-core/tests/unit/jobs/test_scheduler_job.py::TestSchedulerJob::test_dag_start_notifies_with_started_msg - AttributeError: 'SchedulerJobRunner' object has no attribute '_start_dag_runs'. Did you mean: '_create_dag_runs'? > > > root@06119dee0475:/opt/airflow# pytest airflow-core/tests/unit/models/test_dagrun.py > > ========================================== short test summary info =========================================== > XFAIL airflow-core/tests/unit/models/test_dagrun.py::test_schedule_tis_start_trigger - We can't keep this behaviour with remote workers where scheduler can't reach xcom > XFAIL airflow-core/tests/unit/models/test_dagrun.py::test_schedule_tis_start_trigger_through_expand - We can't keep this behaviour with remote workers where scheduler can't reach xcom > ================================ 136 passed, 2 xfailed, 2 warnings in 44.26s ================================= > root@06119dee0475:/opt/airflow# > ``` @jscheffl fixed in https://github.com/apache/airflow/pull/56272/commits/e0019418bab1d4ee4310e73e2552df422e2be5e1 pytests passing now, thanks again `root@06119dee0475:/opt/airflow# pytest airflow-core/tests/unit/jobs/test_scheduler_job.py` ``` ========================================== short test summary info =========================================== SKIPPED [1] devel-common/src/tests_common/pytest_plugin.py:634: The test is skipped because it has long_running marker. And --include-long-running flag is not passed to pytest. <Function test_mapped_dag[test_mapped_classic]> SKIPPED [1] devel-common/src/tests_common/pytest_plugin.py:634: The test is skipped because it has long_running marker. And --include-long-running flag is not passed to pytest. <Function test_mapped_dag[test_mapped_taskflow]> ================================ 237 passed, 2 skipped, 2 warnings in 31.97s ================================= ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
