[
https://issues.apache.org/jira/browse/AIRFLOW-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981198#comment-16981198
]
ASF GitHub Bot commented on AIRFLOW-6057:
-----------------------------------------
mustafagok commented on pull request #6656: [AIRFLOW-6057] Update
template_fields of the PythonSensor
URL: https://github.com/apache/airflow/pull/6656
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6057
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Allow passing Jinja templated arguments to the python_callable of the
PythonSensor (just like in PythonOperator) by adding op_args and op_kwargs to
the template_fields of the PythonSensor.
Also fix the test_python_callable_keyword_arguments_are_templatized test of
the PythonOperator.
### Tests
- [x] My PR adds the following unit tests:
- test_python_callable_arguments_are_templatized for op_args,
- test_python_callable_keyword_arguments_are_templatized for op_kwargs
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add op_args and op_kwargs in PythonSensor templated fields
> ----------------------------------------------------------
>
> Key: AIRFLOW-6057
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6057
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib, operators
> Affects Versions: 1.10.7
> Reporter: Mustafa Gök
> Assignee: Mustafa Gök
> Priority: Minor
>
> Similar Issue: AIRFLOW-1814
> Let's say we have a method that returns True or False and we want to use it
> with PythonSensor, but since the method is used in other applications, we
> don't want to edit this method by adding some XCom pulling code.
> If op_args and op_kwargs are added to the template_fields of the
> PythonSensor, Jinja template can be used.
>
> Note: I am not sure about Components and Affects Versions fields of this
> issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
