This is an automated email from the ASF dual-hosted git repository.
uranusjr pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 2b528c9bf2a Enable PT006 rule to 15 files in helm-tests
(other,security) (#57844)
2b528c9bf2a is described below
commit 2b528c9bf2af56bdaec17e507db911438f5c35a1
Author: Anusha Kovi <[email protected]>
AuthorDate: Wed Nov 5 21:03:10 2025 -0500
Enable PT006 rule to 15 files in helm-tests (other,security) (#57844)
Co-authored-by: Kalyan R <[email protected]>
---
helm-tests/tests/helm_tests/other/test_flower.py | 14 +++++++-------
.../tests/helm_tests/other/test_git_sync_scheduler.py | 2 +-
.../tests/helm_tests/other/test_git_sync_webserver.py | 2 +-
helm-tests/tests/helm_tests/other/test_hpa.py | 6 +++---
helm-tests/tests/helm_tests/other/test_keda.py | 8 ++++----
helm-tests/tests/helm_tests/other/test_pgbouncer.py | 4 ++--
helm-tests/tests/helm_tests/other/test_redis.py | 6 +++---
helm-tests/tests/helm_tests/other/test_statsd.py | 4 ++--
.../tests/helm_tests/security/test_elasticsearch_secret.py | 2 +-
.../helm_tests/security/test_extra_configmaps_secrets.py | 2 +-
.../tests/helm_tests/security/test_opensearch_secret.py | 2 +-
.../tests/helm_tests/security/test_rbac_pod_launcher.py | 12 ++++++++++--
.../tests/helm_tests/security/test_rbac_pod_log_reader.py | 8 ++++----
.../security/test_result_backend_connection_secret.py | 2 +-
.../tests/helm_tests/security/test_scc_rolebinding.py | 6 +++---
15 files changed, 44 insertions(+), 36 deletions(-)
diff --git a/helm-tests/tests/helm_tests/other/test_flower.py
b/helm-tests/tests/helm_tests/other/test_flower.py
index fbca5ff7145..acf34d58355 100644
--- a/helm-tests/tests/helm_tests/other/test_flower.py
+++ b/helm-tests/tests/helm_tests/other/test_flower.py
@@ -25,7 +25,7 @@ class TestFlowerDeployment:
"""Tests flower deployment."""
@pytest.mark.parametrize(
- "executor,flower_enabled,created",
+ ("executor", "flower_enabled", "created"),
[
("CeleryExecutor", False, False),
("CeleryKubernetesExecutor", False, False),
@@ -49,7 +49,7 @@ class TestFlowerDeployment:
assert jmespath.search("spec.template.spec.containers[0].name",
docs[0]) == "flower"
@pytest.mark.parametrize(
- "revision_history_limit, global_revision_history_limit",
+ ("revision_history_limit", "global_revision_history_limit"),
[(8, 10), (10, 8), (8, None), (None, 10), (None, None)],
)
def test_revision_history_limit(self, revision_history_limit,
global_revision_history_limit):
@@ -70,7 +70,7 @@ class TestFlowerDeployment:
assert jmespath.search("spec.revisionHistoryLimit", docs[0]) ==
expected_result
@pytest.mark.parametrize(
- "airflow_version, expected_arg",
+ ("airflow_version", "expected_arg"),
[
("2.0.2", "airflow celery flower"),
("1.10.14", "airflow flower"),
@@ -95,7 +95,7 @@ class TestFlowerDeployment:
]
@pytest.mark.parametrize(
- "command, args",
+ ("command", "args"),
[
(None, None),
(None, ["custom", "args"]),
@@ -464,7 +464,7 @@ class TestFlowerService:
"""Tests flower service."""
@pytest.mark.parametrize(
- "executor,flower_enabled,created",
+ ("executor", "flower_enabled", "created"),
[
("CeleryExecutor", False, False),
("CeleryKubernetesExecutor", False, False),
@@ -524,7 +524,7 @@ class TestFlowerService:
assert jmespath.search("spec.loadBalancerSourceRanges", docs[0]) ==
["10.123.0.0/16"]
@pytest.mark.parametrize(
- "ports, expected_ports",
+ ("ports", "expected_ports"),
[
([{"port": 8888}], [{"port": 8888}]), # name is optional with a
single port
(
@@ -602,7 +602,7 @@ class TestFlowerNetworkPolicy:
assert jmespath.search("spec.ingress[0].ports", docs[0]) == [{"port":
5555}]
@pytest.mark.parametrize(
- "ports, expected_ports",
+ ("ports", "expected_ports"),
[
([{"port": "sidecar"}], [{"port": "sidecar"}]),
(
diff --git a/helm-tests/tests/helm_tests/other/test_git_sync_scheduler.py
b/helm-tests/tests/helm_tests/other/test_git_sync_scheduler.py
index 83c214c99e4..514c38147b1 100644
--- a/helm-tests/tests/helm_tests/other/test_git_sync_scheduler.py
+++ b/helm-tests/tests/helm_tests/other/test_git_sync_scheduler.py
@@ -268,7 +268,7 @@ class TestGitSyncSchedulerTest:
assert "git-sync-ssh-key" not in
jmespath.search("spec.template.spec.volumes[].name", docs[0])
@pytest.mark.parametrize(
- "tag,expected_prefix",
+ ("tag", "expected_prefix"),
[
("v3.6.7", "GIT_SYNC_"),
("v4.4.2", "GITSYNC_"),
diff --git a/helm-tests/tests/helm_tests/other/test_git_sync_webserver.py
b/helm-tests/tests/helm_tests/other/test_git_sync_webserver.py
index d13130e7f65..a9f50367ef8 100644
--- a/helm-tests/tests/helm_tests/other/test_git_sync_webserver.py
+++ b/helm-tests/tests/helm_tests/other/test_git_sync_webserver.py
@@ -75,7 +75,7 @@ class TestGitSyncWebserver:
)
@pytest.mark.parametrize(
- "airflow_version, exclude_webserver",
+ ("airflow_version", "exclude_webserver"),
[
("2.0.0", True),
("2.0.2", True),
diff --git a/helm-tests/tests/helm_tests/other/test_hpa.py
b/helm-tests/tests/helm_tests/other/test_hpa.py
index 9a1318a01b1..626a0063b45 100644
--- a/helm-tests/tests/helm_tests/other/test_hpa.py
+++ b/helm-tests/tests/helm_tests/other/test_hpa.py
@@ -33,7 +33,7 @@ class TestHPA:
assert docs == []
@pytest.mark.parametrize(
- "executor, is_created",
+ ("executor", "is_created"),
[
("CeleryExecutor", True),
("CeleryKubernetesExecutor", True),
@@ -55,7 +55,7 @@ class TestHPA:
assert docs == []
@pytest.mark.parametrize(
- "min_replicas, max_replicas",
+ ("min_replicas", "max_replicas"),
[
(None, None),
(2, 8),
@@ -104,7 +104,7 @@ class TestHPA:
assert jmespath.search("spec.behavior", docs[0]) == expected_behavior
@pytest.mark.parametrize(
- "enabled, kind",
+ ("enabled", "kind"),
[
("enabled", "StatefulSet"),
("not_enabled", "Deployment"),
diff --git a/helm-tests/tests/helm_tests/other/test_keda.py
b/helm-tests/tests/helm_tests/other/test_keda.py
index 192d06f12f6..ef4f369fe80 100644
--- a/helm-tests/tests/helm_tests/other/test_keda.py
+++ b/helm-tests/tests/helm_tests/other/test_keda.py
@@ -33,7 +33,7 @@ class TestKeda:
assert docs == []
@pytest.mark.parametrize(
- "executor, is_created",
+ ("executor", "is_created"),
[
("CeleryExecutor", True),
("CeleryKubernetesExecutor", True),
@@ -113,7 +113,7 @@ class TestKeda:
return query
@pytest.mark.parametrize(
- "executor,concurrency",
+ ("executor", "concurrency"),
[
("CeleryExecutor", 8),
("CeleryExecutor", 16),
@@ -139,7 +139,7 @@ class TestKeda:
assert jmespath.search("spec.triggers[0].metadata.query", docs[0]) ==
expected_query
@pytest.mark.parametrize(
- "executor,queue,should_filter",
+ ("executor", "queue", "should_filter"),
[
("CeleryExecutor", None, False),
("CeleryExecutor", "my_queue", False),
@@ -170,7 +170,7 @@ class TestKeda:
assert jmespath.search("spec.triggers[0].metadata.query", docs[0]) ==
expected_query
@pytest.mark.parametrize(
- "enabled, kind",
+ ("enabled", "kind"),
[
("enabled", "StatefulSet"),
("not_enabled", "Deployment"),
diff --git a/helm-tests/tests/helm_tests/other/test_pgbouncer.py
b/helm-tests/tests/helm_tests/other/test_pgbouncer.py
index 156c7c97900..857ae069c3e 100644
--- a/helm-tests/tests/helm_tests/other/test_pgbouncer.py
+++ b/helm-tests/tests/helm_tests/other/test_pgbouncer.py
@@ -109,7 +109,7 @@ class TestPgbouncer:
assert jmespath.search("spec.clusterIP", docs[0]) == "10.10.10.10"
@pytest.mark.parametrize(
- "revision_history_limit, global_revision_history_limit",
+ ("revision_history_limit", "global_revision_history_limit"),
[(8, 10), (10, 8), (8, None), (None, 10), (None, None)],
)
def test_revision_history_limit(self, revision_history_limit,
global_revision_history_limit):
@@ -850,7 +850,7 @@ class TestPgbouncerNetworkPolicy:
assert jmespath.search("metadata.name", docs[0]) ==
"release-name-pgbouncer-policy"
@pytest.mark.parametrize(
- "conf, expected_selector",
+ ("conf", "expected_selector"),
[
# test with workers.keda enabled without namespace labels
(
diff --git a/helm-tests/tests/helm_tests/other/test_redis.py
b/helm-tests/tests/helm_tests/other/test_redis.py
index 44e91851d22..3527547d601 100644
--- a/helm-tests/tests/helm_tests/other/test_redis.py
+++ b/helm-tests/tests/helm_tests/other/test_redis.py
@@ -411,7 +411,7 @@ class TestRedis:
assert
jmespath.search("spec.volumeClaimTemplates[0].metadata.annotations", docs[0])
== {"foo": "bar"}
@pytest.mark.parametrize(
- "redis_values, expected",
+ ("redis_values", "expected"),
[
({"persistence": {"enabled": False}}, {"emptyDir": {}}),
(
@@ -462,7 +462,7 @@ class TestRedis:
} in jmespath.search("spec.template.spec.volumes", docs[0])
@pytest.mark.parametrize(
- "redis_values, expected",
+ ("redis_values", "expected"),
[
({}, 600),
({"redis": {"terminationGracePeriodSeconds": 1200}}, 1200),
@@ -506,7 +506,7 @@ class TestRedisService:
"""Tests redis service."""
@pytest.mark.parametrize(
- "redis_values, expected",
+ ("redis_values", "expected"),
[
({"redis": {"service": {"type": "ClusterIP"}}}, "ClusterIP"),
({"redis": {"service": {"type": "NodePort"}}}, "NodePort"),
diff --git a/helm-tests/tests/helm_tests/other/test_statsd.py
b/helm-tests/tests/helm_tests/other/test_statsd.py
index dad5bb26304..21815aff5e4 100644
--- a/helm-tests/tests/helm_tests/other/test_statsd.py
+++ b/helm-tests/tests/helm_tests/other/test_statsd.py
@@ -88,7 +88,7 @@ class TestStatsd:
} in jmespath.search("spec.template.spec.containers[0].volumeMounts",
docs[0])
@pytest.mark.parametrize(
- "revision_history_limit, global_revision_history_limit",
+ ("revision_history_limit", "global_revision_history_limit"),
[(8, 10), (10, 8), (8, None), (None, 10), (None, None)],
)
def test_revision_history_limit(self, revision_history_limit,
global_revision_history_limit):
@@ -350,7 +350,7 @@ class TestStatsd:
assert jmespath.search("metadata.annotations",
docs)["test_annotation"] == "test_annotation_value"
@pytest.mark.parametrize(
- "statsd_values, expected",
+ ("statsd_values", "expected"),
[
({}, 30),
({"statsd": {"terminationGracePeriodSeconds": 1200}}, 1200),
diff --git a/helm-tests/tests/helm_tests/security/test_elasticsearch_secret.py
b/helm-tests/tests/helm_tests/security/test_elasticsearch_secret.py
index 08e2061400b..82feea07b7b 100644
--- a/helm-tests/tests/helm_tests/security/test_elasticsearch_secret.py
+++ b/helm-tests/tests/helm_tests/security/test_elasticsearch_secret.py
@@ -90,7 +90,7 @@ class TestElasticsearchSecret:
assert f"{scheme}://username:password@elastichostname:9200" ==
connection
@pytest.mark.parametrize(
- "extra_conn_kwargs, expected_user_info",
+ ("extra_conn_kwargs", "expected_user_info"),
[
# When both user and password are empty.
({}, ""),
diff --git
a/helm-tests/tests/helm_tests/security/test_extra_configmaps_secrets.py
b/helm-tests/tests/helm_tests/security/test_extra_configmaps_secrets.py
index 6ad318ed36f..3056fcb7aa5 100644
--- a/helm-tests/tests/helm_tests/security/test_extra_configmaps_secrets.py
+++ b/helm-tests/tests/helm_tests/security/test_extra_configmaps_secrets.py
@@ -153,7 +153,7 @@ class TestExtraConfigMapsSecrets:
assert k8s_object["metadata"]["labels"] == expected_labels
@pytest.mark.parametrize(
- "chart_labels, local_labels",
+ ("chart_labels", "local_labels"),
[
({}, {"label3": "value3", "label4": "value4"}),
({"label1": "value1", "label2": "value2"}, {}),
diff --git a/helm-tests/tests/helm_tests/security/test_opensearch_secret.py
b/helm-tests/tests/helm_tests/security/test_opensearch_secret.py
index 8ee29ac7291..94e4fa02eb6 100644
--- a/helm-tests/tests/helm_tests/security/test_opensearch_secret.py
+++ b/helm-tests/tests/helm_tests/security/test_opensearch_secret.py
@@ -90,7 +90,7 @@ class TestOpenSearchSecret:
assert f"{scheme}://username:password@opensearchhostname:9200" ==
connection
@pytest.mark.parametrize(
- "extra_conn_kwargs, expected_user_info",
+ ("extra_conn_kwargs", "expected_user_info"),
[
# When both user and password are empty.
({}, ""),
diff --git a/helm-tests/tests/helm_tests/security/test_rbac_pod_launcher.py
b/helm-tests/tests/helm_tests/security/test_rbac_pod_launcher.py
index 11d185e47c2..6c0ba03f10b 100644
--- a/helm-tests/tests/helm_tests/security/test_rbac_pod_launcher.py
+++ b/helm-tests/tests/helm_tests/security/test_rbac_pod_launcher.py
@@ -25,7 +25,7 @@ class TestPodLauncher:
"""Tests RBAC Pod Launcher."""
@pytest.mark.parametrize(
- "rbac_create, allow_pod_launching, multi_ns, expected_kind,
expected_name",
+ ("rbac_create", "allow_pod_launching", "multi_ns", "expected_kind",
"expected_name"),
[
(True, True, False, "Role", "release-name-pod-launcher-role"),
(True, True, True, "ClusterRole",
"default-release-name-pod-launcher-role"),
@@ -51,7 +51,15 @@ class TestPodLauncher:
assert docs[0]["metadata"]["name"] == expected_name
@pytest.mark.parametrize(
- "rbac_create, allow_pod_launching, executor, dedicated_sa,
triggerer_enabled, multi_ns, expected_subjects",
+ (
+ "rbac_create",
+ "allow_pod_launching",
+ "executor",
+ "dedicated_sa",
+ "triggerer_enabled",
+ "multi_ns",
+ "expected_subjects",
+ ),
[
# Only scheduler and worker SAs for KubernetesExecutor,
CeleryExecutor
(
diff --git a/helm-tests/tests/helm_tests/security/test_rbac_pod_log_reader.py
b/helm-tests/tests/helm_tests/security/test_rbac_pod_log_reader.py
index 3cd500cd550..fe0d4ebc662 100644
--- a/helm-tests/tests/helm_tests/security/test_rbac_pod_log_reader.py
+++ b/helm-tests/tests/helm_tests/security/test_rbac_pod_log_reader.py
@@ -25,7 +25,7 @@ class TestPodReader:
"""Tests RBAC Pod Reader."""
@pytest.mark.parametrize(
- "webserver, airflow_version, expected",
+ ("webserver", "airflow_version", "expected"),
[
(True, "2.9.0", ["release-name-airflow-webserver"]),
(False, "2.9.0", []),
@@ -46,7 +46,7 @@ class TestPodReader:
assert actual == expected
@pytest.mark.parametrize(
- "webserver, expected",
+ ("webserver", "expected"),
[
(True, "release-name-pod-log-reader-role"),
(False, None),
@@ -63,7 +63,7 @@ class TestPodReader:
assert actual == expected
@pytest.mark.parametrize(
- "multiNamespaceMode, namespace, expectedRole, expectedRoleBinding",
+ ("multiNamespaceMode", "namespace", "expectedRole",
"expectedRoleBinding"),
[
(
True,
@@ -110,7 +110,7 @@ class TestPodReader:
assert actualRoleRefKind == "Role"
@pytest.mark.parametrize(
- "multiNamespaceMode, namespace, expectedRole",
+ ("multiNamespaceMode", "namespace", "expectedRole"),
[
(True, "namespace", "namespace-release-name-pod-log-reader-role"),
(True, "other-ns", "other-ns-release-name-pod-log-reader-role"),
diff --git
a/helm-tests/tests/helm_tests/security/test_result_backend_connection_secret.py
b/helm-tests/tests/helm_tests/security/test_result_backend_connection_secret.py
index 4a9c1253486..1d97ba44eb7 100644
---
a/helm-tests/tests/helm_tests/security/test_result_backend_connection_secret.py
+++
b/helm-tests/tests/helm_tests/security/test_result_backend_connection_secret.py
@@ -56,7 +56,7 @@ class TestResultBackendConnectionSecret:
assert len(docs) == 0
@pytest.mark.parametrize(
- "executor, expected_doc_count",
+ ("executor", "expected_doc_count"),
[
("CeleryExecutor", 1),
("CeleryKubernetesExecutor", 1),
diff --git a/helm-tests/tests/helm_tests/security/test_scc_rolebinding.py
b/helm-tests/tests/helm_tests/security/test_scc_rolebinding.py
index 76e7b7d2183..0997deb4e2e 100644
--- a/helm-tests/tests/helm_tests/security/test_scc_rolebinding.py
+++ b/helm-tests/tests/helm_tests/security/test_scc_rolebinding.py
@@ -25,7 +25,7 @@ class TestSCCActivation:
"""Tests SCCs."""
@pytest.mark.parametrize(
- "rbac_enabled,scc_enabled,created",
+ ("rbac_enabled", "scc_enabled", "created"),
[
(False, False, False),
(False, True, False),
@@ -64,7 +64,7 @@ class TestSCCActivation:
assert jmespath.search("subjects[9].name", docs[0]) ==
"release-name-airflow-dag-processor"
@pytest.mark.parametrize(
- "rbac_enabled,scc_enabled,created,namespace,expected_name",
+ ("rbac_enabled", "scc_enabled", "created", "namespace",
"expected_name"),
[
(True, True, True, "default",
"default-release-name-scc-rolebinding"),
(True, True, True, "other-ns",
"other-ns-release-name-scc-rolebinding"),
@@ -91,7 +91,7 @@ class TestSCCActivation:
assert jmespath.search("roleRef.name", docs[0]) ==
"system:openshift:scc:anyuid"
@pytest.mark.parametrize(
- "rbac_enabled,scc_enabled,created",
+ ("rbac_enabled", "scc_enabled", "created"),
[
(True, True, True),
],
