uranusjr commented on code in PR #55274:
URL: https://github.com/apache/airflow/pull/55274#discussion_r2497196827


##########
airflow-core/src/airflow/models/dag.py:
##########
@@ -580,7 +580,7 @@ def deactivate_deleted_dags(
                 dm.is_stale = True
 
     @classmethod
-    def dags_needing_dagruns(cls, session: Session) -> tuple[Query, dict[str, 
datetime]]:
+    def dags_needing_dagruns(cls, session: Session) -> 
tuple[ScalarResult[Any], dict[str, datetime]]:

Review Comment:
   Can we annotate this as ScalarResult[DagModel] instead? Same for other 
things below, it would e much better if they annotate what type is being 
returned (instead of Any)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to