MaksYermak commented on PR #57514: URL: https://github.com/apache/airflow/pull/57514#issuecomment-3497824423
> Thanks for the thorough investigation! LGTM, I think that we're good to go and we could handle the mentioned issues later. > > @MaksYermak do you have additional comments before merging? @juarezr thank you for your explanation and deep research! @shahar1 yes I have one more comment. I have checked the code and I noticed that [field_to_bigquery](https://github.com/apache/airflow/blob/main/providers/google/src/airflow/providers/google/cloud/transfers/mssql_to_gcs.py#L98) from `MSSQLToGCSOperator` is only one function in the code which uses values from `self.type_map` which is changed by this PR. This function is called in two places [_convert_parquet_schema](https://github.com/apache/airflow/blob/main/providers/google/src/airflow/providers/google/cloud/transfers/sql_to_gcs.py#L387) and [_write_local_schema_file](https://github.com/apache/airflow/blob/main/providers/google/src/airflow/providers/google/cloud/transfers/sql_to_gcs.py#L441). As we know this PR fixes the problem in `_convert_parquet_schema`. But I am not sure that this code does not affect the `_write_local_schema_file` function which the code uses for generate schema in `json` format. I see that `_write_local_schema_file` runs `field_to_bigquery` in case when for the operator `schema_filename` is pr esent and `schema` is not present, [here](https://github.com/apache/airflow/blob/main/providers/google/src/airflow/providers/google/cloud/transfers/sql_to_gcs.py#L457). @juarezr could I ask to check the scenario with JSON format for `MSSQLToGCSOperator` when in parameters `schema_filename` is present and `schema` is not present and share with us the results that file with schema is generating successfully for JSON format? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
