potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to 
avoid cyclic imports. Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#issuecomment-558068379
 
 
   I think I have 3 tests in Celery Executor to go. Interesting thing - I think 
I managed to reproduce the dreadful while using some real tasks during the 
executor tests:
   
   ```
   TypeError: can't pickle _thread.lock objects 
   ```
   
   The old CeleryExecutor tests were using some totally artificial tasks 
(strings rather than complex tuples) - seems like those tests were not touched 
since the beginning and the tuples sent in executor got more and more complex. 
I am updating the tests to be more "real" (following the typing hints I got 
now), but I would appreciate already starting a look. 
   
   There are more people suffering now from the cyclic dependencies detected by 
pylint - without fixing it might be blocker to merge stuff.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to