potiuk commented on PR #56187: URL: https://github.com/apache/airflow/pull/56187#issuecomment-3498846992
> @potiuk Thank you! > > There are some other issues apart from `prek` adding dependencies. Let's assume that I make the OpenTelemetry dependency optional. What will happen with the OpenTelemetry imports? Won't we get in the CI that the package doesn't exist? I think that's what happened last time I tried this. There are ways - we can add a compatibility code with import fallbacks if things are to be made optional. We have quite a number of those - often they require some small refactors and separating out things to a separate package where the fallbacks are handled, but .... this is precisely this kind of move :). We also might make some tests optional in this case and depend on presence of open-telemetry, we also might want to make sure that the current code that builds the CI uses those optional dependencies to build the CI image. This is the code (pretty complex) that installs airflow and related packages in CI in the image depending on circumstances: https://github.com/apache/airflow/blob/main/scripts/docker/install_airflow_when_building_images.sh#L38 So likely this code will need to be updated if opentelemetry is made truly optional, to actually install the extras required This is when I might step-in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
