chiuinggum commented on code in PR #57480:
URL: https://github.com/apache/airflow/pull/57480#discussion_r2501803283
##########
providers/fab/src/airflow/providers/fab/auth_manager/api_fastapi/datamodels/roles.py:
##########
@@ -40,6 +40,12 @@ class ActionResourceResponse(BaseModel):
resource: ResourceResponse
+class RoleRef(BaseModel):
Review Comment:
>I also realized in this file we have models such as
`ActionResourceResponse` that is used in responses but requests as well. In
that case could you rename them `ActionResource`. Same for `ActionResponse` and
`ResourceResponse`
may i fix this in the next PR? I want to keep the scope of this PR to /users
API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
