potiuk commented on code in PR #58039:
URL: https://github.com/apache/airflow/pull/58039#discussion_r2503369215
##########
dev/breeze/doc/03_developer_tasks.rst:
##########
@@ -274,6 +274,22 @@ For example, this following command:
prek mypy-airflow
will run mypy check for currently staged files inside ``airflow/`` excluding
providers.
+.. _breeze-dev:running-prek-in-breeze:
+
+A note on running ``prek`` inside the Breeze container
+-----------------------------------------------------
+
+While ``prek`` (pre-commit) is intended to be run on your host machine, it can
+also be run from within the Breeze shell for debugging or manual checks.
+
+If you choose to do this, you may need to mount all sources by running
+``breeze shell --mount-sources all``.
+
+.. note::
+ In older versions of Airflow, running ``prek`` inside a non-TTY
+ environment (like the Breeze shell) would cause an ``AttributeError``
+ crash. This was fixed in :pr:`57497` and ``prek`` can now be
+ run safely inside the container.
Review Comment:
```suggestion
```
Let's remove it - we generally run breeze from "main" - this is already a
history (and captured in Git) - there is no point in making reference to it in
"main" docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
