This is an automated email from the ASF dual-hosted git repository.
shahar pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 5b9436bc419 Enable PT006 rule to openlineage Provider test (#57940)
5b9436bc419 is described below
commit 5b9436bc419d4f3830bdf9d6dda17b042e1f6199
Author: GUAN-HAO HUANG <[email protected]>
AuthorDate: Sat Nov 8 02:38:36 2025 +0800
Enable PT006 rule to openlineage Provider test (#57940)
---
.../openlineage/tests/unit/openlineage/extractors/test_base.py | 2 +-
.../openlineage/tests/unit/openlineage/operators/test_empty.py | 2 +-
.../openlineage/tests/unit/openlineage/plugins/test_adapter.py | 2 +-
.../tests/unit/openlineage/plugins/test_listener.py | 10 +++++-----
.../tests/unit/openlineage/plugins/test_openlineage.py | 2 +-
.../openlineage/tests/unit/openlineage/utils/test_spark.py | 10 +++++-----
providers/openlineage/tests/unit/openlineage/utils/test_sql.py | 2 +-
.../openlineage/tests/unit/openlineage/utils/test_utils.py | 4 ++--
8 files changed, 17 insertions(+), 17 deletions(-)
diff --git
a/providers/openlineage/tests/unit/openlineage/extractors/test_base.py
b/providers/openlineage/tests/unit/openlineage/extractors/test_base.py
index d5647e3f3b0..71ce953c835 100644
--- a/providers/openlineage/tests/unit/openlineage/extractors/test_base.py
+++ b/providers/openlineage/tests/unit/openlineage/extractors/test_base.py
@@ -314,7 +314,7 @@ def test_extraction_without_on_start():
@pytest.mark.parametrize(
- "operator_class, task_state, expected_job_facets",
+ ("operator_class", "task_state", "expected_job_facets"),
(
(OperatorWithAllOlMethods, TaskInstanceState.FAILED, FAILED_FACETS),
(OperatorWithAllOlMethods, TaskInstanceState.RUNNING, JOB_FACETS),
diff --git
a/providers/openlineage/tests/unit/openlineage/operators/test_empty.py
b/providers/openlineage/tests/unit/openlineage/operators/test_empty.py
index ab7427d63ad..8d7967cf1af 100644
--- a/providers/openlineage/tests/unit/openlineage/operators/test_empty.py
+++ b/providers/openlineage/tests/unit/openlineage/operators/test_empty.py
@@ -32,7 +32,7 @@ def test_execute_returns_none_and_does_not_raise():
@pytest.mark.parametrize(
- "method_name,use_task_instance",
+ ("method_name", "use_task_instance"),
[
("get_openlineage_facets_on_start", False),
("get_openlineage_facets_on_complete", True),
diff --git
a/providers/openlineage/tests/unit/openlineage/plugins/test_adapter.py
b/providers/openlineage/tests/unit/openlineage/plugins/test_adapter.py
index 4b9044202ad..28a533643a3 100644
--- a/providers/openlineage/tests/unit/openlineage/plugins/test_adapter.py
+++ b/providers/openlineage/tests/unit/openlineage/plugins/test_adapter.py
@@ -61,7 +61,7 @@ from tests_common.test_utils.version_compat import
AIRFLOW_V_3_0_PLUS
@pytest.mark.parametrize(
- "env_vars, expected_logging",
+ ("env_vars", "expected_logging"),
[
({"AIRFLOW__LOGGING__LOGGING_LEVEL": "DEBUG"}, "DEBUG"),
({"AIRFLOW__LOGGING__LOGGING_LEVEL": "INFO"}, None),
diff --git
a/providers/openlineage/tests/unit/openlineage/plugins/test_listener.py
b/providers/openlineage/tests/unit/openlineage/plugins/test_listener.py
index 76b743f1a82..bc3589b267c 100644
--- a/providers/openlineage/tests/unit/openlineage/plugins/test_listener.py
+++ b/providers/openlineage/tests/unit/openlineage/plugins/test_listener.py
@@ -858,7 +858,7 @@ class TestOpenLineageListenerAirflow2:
listener.adapter.complete_task.assert_not_called()
@pytest.mark.parametrize(
- "max_workers,expected",
+ ("max_workers", "expected"),
[
(None, 1),
("8", 8),
@@ -1787,7 +1787,7 @@ class TestOpenLineageListenerAirflow3:
listener.adapter.complete_task.assert_not_called()
@pytest.mark.parametrize(
- "max_workers,expected",
+ ("max_workers", "expected"),
[
(None, 1),
("8", 8),
@@ -1897,7 +1897,7 @@ class TestOpenLineageSelectiveEnableAirflow2:
clear_db_runs()
@pytest.mark.parametrize(
- "selective_enable, enable_dag, expected_call_count",
+ ("selective_enable", "enable_dag", "expected_call_count"),
[
("True", True, 3),
("False", True, 3),
@@ -1921,7 +1921,7 @@ class TestOpenLineageSelectiveEnableAirflow2:
listener.on_dag_run_success(self.dagrun, msg="test success")
@pytest.mark.parametrize(
- "selective_enable, enable_task, expected_dag_call_count,
expected_task_call_count",
+ ("selective_enable", "enable_task", "expected_dag_call_count",
"expected_task_call_count"),
[
("True", True, 3, 3),
("False", True, 3, 3),
@@ -1978,7 +1978,7 @@ class TestOpenLineageSelectiveEnableAirflow2:
assert expected_task_call_count ==
listener.extractor_manager.extract_metadata.call_count
@pytest.mark.parametrize(
- "selective_enable, enable_task, expected_call_count,
expected_task_call_count",
+ ("selective_enable", "enable_task", "expected_call_count",
"expected_task_call_count"),
[
("True", True, 3, 3),
("False", True, 3, 3),
diff --git
a/providers/openlineage/tests/unit/openlineage/plugins/test_openlineage.py
b/providers/openlineage/tests/unit/openlineage/plugins/test_openlineage.py
index cb50dfc8170..0116c7985b0 100644
--- a/providers/openlineage/tests/unit/openlineage/plugins/test_openlineage.py
+++ b/providers/openlineage/tests/unit/openlineage/plugins/test_openlineage.py
@@ -38,7 +38,7 @@ class TestOpenLineageProviderPlugin:
del
sys.modules["airflow.providers.openlineage.plugins.openlineage"]
@pytest.mark.parametrize(
- "mocks, expected",
+ ("mocks", "expected"),
[
# 0: not disabled but no configuration found
([], 0),
diff --git a/providers/openlineage/tests/unit/openlineage/utils/test_spark.py
b/providers/openlineage/tests/unit/openlineage/utils/test_spark.py
index 5403dab5497..eb910114789 100644
--- a/providers/openlineage/tests/unit/openlineage/utils/test_spark.py
+++ b/providers/openlineage/tests/unit/openlineage/utils/test_spark.py
@@ -150,7 +150,7 @@ def
test_get_transport_information_as_spark_properties_composite_transport_type(
@pytest.mark.parametrize(
- "properties, expected",
+ ("properties", "expected"),
[
(
{"spark.openlineage.parentJobNamespace": "example_namespace"},
@@ -194,7 +194,7 @@ def
test_is_parent_job_information_present_in_spark_properties(properties, expec
@pytest.mark.parametrize(
- "properties, expected",
+ ("properties", "expected"),
[
(
{"spark.openlineage.transport": "example_namespace"},
@@ -227,7 +227,7 @@ def
test_is_transport_information_present_in_spark_properties(properties, expect
@pytest.mark.parametrize(
- "properties, should_inject",
+ ("properties", "should_inject"),
[
(
{"spark.openlineage.parentJobNamespace": "example_namespace"},
@@ -270,7 +270,7 @@ def
test_inject_parent_job_information_into_spark_properties(properties, should_
@pytest.mark.parametrize(
- "properties, should_inject",
+ ("properties", "should_inject"),
[
(
{"spark.openlineage.transport": "example_namespace"},
@@ -309,7 +309,7 @@ def
test_inject_transport_information_into_spark_properties(mock_ol_listener, pr
@pytest.mark.parametrize(
- "properties, should_inject",
+ ("properties", "should_inject"),
[
(
{"spark.openlineage.transport": "example_namespace"},
diff --git a/providers/openlineage/tests/unit/openlineage/utils/test_sql.py
b/providers/openlineage/tests/unit/openlineage/utils/test_sql.py
index 2e2f36ca74d..aa699d38dae 100644
--- a/providers/openlineage/tests/unit/openlineage/utils/test_sql.py
+++ b/providers/openlineage/tests/unit/openlineage/utils/test_sql.py
@@ -250,7 +250,7 @@ def test_get_table_schemas_with_other_database():
@pytest.mark.parametrize(
- "schema_mapping, expected",
+ ("schema_mapping", "expected"),
[
pytest.param({None: {None: ["C1", "C2"]}},
"information_schema.columns.table_name IN ('C1', 'C2')"),
pytest.param(
diff --git a/providers/openlineage/tests/unit/openlineage/utils/test_utils.py
b/providers/openlineage/tests/unit/openlineage/utils/test_utils.py
index 198280426a3..c6eb43e445f 100644
--- a/providers/openlineage/tests/unit/openlineage/utils/test_utils.py
+++ b/providers/openlineage/tests/unit/openlineage/utils/test_utils.py
@@ -369,7 +369,7 @@ def test_truncate_string_to_byte_size_non_bmp_characters():
@pytest.mark.parametrize(
- "operator, expected_doc, expected_mime_type",
+ ("operator", "expected_doc", "expected_mime_type"),
[
(None, None, None),
(MagicMock(doc=None, doc_md=None, doc_json=None, doc_yaml=None,
doc_rst=None), None, None),
@@ -425,7 +425,7 @@ def test_get_task_documentation_longer_than_allowed():
@pytest.mark.parametrize(
- "dag, expected_doc, expected_mime_type",
+ ("dag", "expected_doc", "expected_mime_type"),
[
(None, None, None),
(MagicMock(doc_md=None, description=None), None, None),
