This is an automated email from the ASF dual-hosted git repository.
shahar pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 2c12bff3edd Enable PT006 rule to standard Provider test(ssensor,
trigge, util) 9 files (#58022)
2c12bff3edd is described below
commit 2c12bff3eddc8c6607052db14e6c46dfdc8b9717
Author: ChenChen Lai <[email protected]>
AuthorDate: Sat Nov 8 02:53:28 2025 +0800
Enable PT006 rule to standard Provider test(ssensor, trigge, util) 9 files
(#58022)
Signed-off-by: Your Name <[email protected]>
Co-authored-by: Kalyan R <[email protected]>
---
.../standard/tests/unit/standard/sensors/test_date_time.py | 6 +++---
.../tests/unit/standard/sensors/test_external_task_sensor.py | 10 +++++-----
providers/standard/tests/unit/standard/sensors/test_time.py | 4 ++--
.../tests/unit/standard/triggers/test_external_task.py | 11 ++++++++++-
.../standard/tests/unit/standard/triggers/test_temporal.py | 2 +-
.../tests/unit/standard/utils/test_python_virtualenv.py | 2 +-
.../standard/tests/unit/standard/utils/test_sensor_helper.py | 2 +-
.../standard/tests/unit/standard/utils/test_skipmixin.py | 4 ++--
providers/standard/tests/unit/standard/utils/test_weekday.py | 4 ++--
9 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/providers/standard/tests/unit/standard/sensors/test_date_time.py
b/providers/standard/tests/unit/standard/sensors/test_date_time.py
index 48be29f8ef8..6b07eae4948 100644
--- a/providers/standard/tests/unit/standard/sensors/test_date_time.py
+++ b/providers/standard/tests/unit/standard/sensors/test_date_time.py
@@ -38,7 +38,7 @@ class TestDateTimeSensor:
cls.dag = DAG("test_dag", schedule=None, default_args=args)
@pytest.mark.parametrize(
- "task_id, target_time, expected",
+ ("task_id", "target_time", "expected"),
[
(
"valid_datetime",
@@ -75,7 +75,7 @@ class TestDateTimeSensor:
)
@pytest.mark.parametrize(
- "task_id, target_time, expected",
+ ("task_id", "target_time", "expected"),
[
(
"poke_datetime",
@@ -95,7 +95,7 @@ class TestDateTimeSensor:
assert op.poke(None) == expected
@pytest.mark.parametrize(
- "native, target_time, expected_type",
+ ("native", "target_time", "expected_type"),
[
(False, "2025-01-01T00:00:00+00:00", pendulum.DateTime),
(True, "{{ data_interval_end }}", pendulum.DateTime),
diff --git
a/providers/standard/tests/unit/standard/sensors/test_external_task_sensor.py
b/providers/standard/tests/unit/standard/sensors/test_external_task_sensor.py
index 587c36837ae..e4597c982e5 100644
---
a/providers/standard/tests/unit/standard/sensors/test_external_task_sensor.py
+++
b/providers/standard/tests/unit/standard/sensors/test_external_task_sensor.py
@@ -859,7 +859,7 @@ exit 0
)
@pytest.mark.parametrize(
- "kwargs, expected_message",
+ ("kwargs", "expected_message"),
(
(
{
@@ -884,7 +884,7 @@ exit 0
),
)
@pytest.mark.parametrize(
- "soft_fail, expected_exception",
+ ("soft_fail", "expected_exception"),
(
(
False,
@@ -932,7 +932,7 @@ exit 0
op.execute(context={})
@pytest.mark.parametrize(
- "response_get_current, response_exists, kwargs, expected_message",
+ ("response_get_current", "response_exists", "kwargs",
"expected_message"),
(
(None, None, {}, f"The external DAG {TEST_DAG_ID} does not
exist."),
(
@@ -957,7 +957,7 @@ exit 0
),
)
@pytest.mark.parametrize(
- "soft_fail, expected_exception",
+ ("soft_fail", "expected_exception"),
(
(
False,
@@ -1520,7 +1520,7 @@ class TestExternalTaskAsyncSensor:
@pytest.mark.skipif(not AIRFLOW_V_3_0_PLUS, reason="Needs Flask app context
fixture for AF 2")
@pytest.mark.parametrize(
- argnames=["external_dag_id", "external_task_id",
"expected_external_dag_id", "expected_external_task_id"],
+ argnames=("external_dag_id", "external_task_id",
"expected_external_dag_id", "expected_external_task_id"),
argvalues=[
("dag_test", "task_test", "dag_test", "task_test"),
("dag_{{ ds }}", "task_{{ ds }}", f"dag_{DEFAULT_DATE.date()}",
f"task_{DEFAULT_DATE.date()}"),
diff --git a/providers/standard/tests/unit/standard/sensors/test_time.py
b/providers/standard/tests/unit/standard/sensors/test_time.py
index bcc2e44fee8..aeaefc193e7 100644
--- a/providers/standard/tests/unit/standard/sensors/test_time.py
+++ b/providers/standard/tests/unit/standard/sensors/test_time.py
@@ -40,7 +40,7 @@ DEFAULT_DATE_WITH_TZ = datetime(2015, 1, 1,
tzinfo=DEFAULT_TIMEZONE)
class TestTimeSensor:
@pytest.mark.parametrize(
- "tzinfo, start_date, target_time ,expected",
+ ("tzinfo", "start_date", "target_time", "expected"),
[
(timezone.utc, DEFAULT_DATE_WO_TZ, time(10, 0), True),
(timezone.utc, DEFAULT_DATE_WITH_TZ, time(16, 0), True),
@@ -63,7 +63,7 @@ class TestTimeSensor:
assert op.target_datetime.tzinfo == timezone.utc
@pytest.mark.parametrize(
- "current_datetime, server_timezone",
+ ("current_datetime", "server_timezone"),
[
("2025-01-26 22:00:00", "UTC"),
("2025-01-27 07:00:00", "Asia/Seoul"), # UTC+09:00
diff --git
a/providers/standard/tests/unit/standard/triggers/test_external_task.py
b/providers/standard/tests/unit/standard/triggers/test_external_task.py
index 492087b2c56..4a970fd752e 100644
--- a/providers/standard/tests/unit/standard/triggers/test_external_task.py
+++ b/providers/standard/tests/unit/standard/triggers/test_external_task.py
@@ -224,7 +224,16 @@ class TestWorkflowTrigger:
assert mock_sleep.await_count == 1
@pytest.mark.parametrize(
- "task_ids, task_group_id, states, logical_dates, mock_ti_count,
mock_task_states, mock_dag_count, expected",
+ (
+ "task_ids",
+ "task_group_id",
+ "states",
+ "logical_dates",
+ "mock_ti_count",
+ "mock_task_states",
+ "mock_dag_count",
+ "expected",
+ ),
[
(
["task_id_one", "task_id_two"],
diff --git a/providers/standard/tests/unit/standard/triggers/test_temporal.py
b/providers/standard/tests/unit/standard/triggers/test_temporal.py
index fc85eab8273..fd2e3596a62 100644
--- a/providers/standard/tests/unit/standard/triggers/test_temporal.py
+++ b/providers/standard/tests/unit/standard/triggers/test_temporal.py
@@ -75,7 +75,7 @@ def test_timedelta_trigger_serialization():
@pytest.mark.parametrize(
- "tz, end_from_trigger",
+ ("tz", "end_from_trigger"),
[
(pendulum.timezone("UTC"), True),
(pendulum.timezone("UTC"), False), # only really need to test one
diff --git
a/providers/standard/tests/unit/standard/utils/test_python_virtualenv.py
b/providers/standard/tests/unit/standard/utils/test_python_virtualenv.py
index fca9c3da162..2aaa9a1283d 100644
--- a/providers/standard/tests/unit/standard/utils/test_python_virtualenv.py
+++ b/providers/standard/tests/unit/standard/utils/test_python_virtualenv.py
@@ -206,7 +206,7 @@ class TestPrepareVirtualenv:
)
@pytest.mark.parametrize(
- "decorators, expected_decorators",
+ ("decorators", "expected_decorators"),
[
(["@task.virtualenv"], []),
(["@task.virtualenv()"], []),
diff --git a/providers/standard/tests/unit/standard/utils/test_sensor_helper.py
b/providers/standard/tests/unit/standard/utils/test_sensor_helper.py
index 9265b292fcc..c94f05b56bd 100644
--- a/providers/standard/tests/unit/standard/utils/test_sensor_helper.py
+++ b/providers/standard/tests/unit/standard/utils/test_sensor_helper.py
@@ -412,7 +412,7 @@ class TestSensorHelper:
@pytest.mark.parametrize(
- "run_id_task_state_map, states, expected_count",
+ ("run_id_task_state_map", "states", "expected_count"),
[
pytest.param(
{
diff --git a/providers/standard/tests/unit/standard/utils/test_skipmixin.py
b/providers/standard/tests/unit/standard/utils/test_skipmixin.py
index ac66c89d7e2..db5da0f4536 100644
--- a/providers/standard/tests/unit/standard/utils/test_skipmixin.py
+++ b/providers/standard/tests/unit/standard/utils/test_skipmixin.py
@@ -128,7 +128,7 @@ class TestSkipMixin:
assert exc_info.value.tasks == ["task"]
@pytest.mark.parametrize(
- "branch_task_ids, expected_states",
+ ("branch_task_ids", "expected_states"),
[
(None, {"task2": State.SKIPPED, "task3": State.SKIPPED}),
([], {"task2": State.SKIPPED, "task3": State.SKIPPED}),
@@ -176,7 +176,7 @@ class TestSkipMixin:
assert executed_states == expected_states
@pytest.mark.parametrize(
- "branch_task_ids, expected_states",
+ ("branch_task_ids", "expected_states"),
[
(["task2"], {"task2": State.NONE, "task3": State.SKIPPED}),
(("task2",), {"task2": State.NONE, "task3": State.SKIPPED}),
diff --git a/providers/standard/tests/unit/standard/utils/test_weekday.py
b/providers/standard/tests/unit/standard/utils/test_weekday.py
index 9aef86c46b4..5bec8a6d936 100644
--- a/providers/standard/tests/unit/standard/utils/test_weekday.py
+++ b/providers/standard/tests/unit/standard/utils/test_weekday.py
@@ -43,7 +43,7 @@ class TestWeekDay:
assert isinstance(weekday_enum, Enum)
@pytest.mark.parametrize(
- "weekday, expected",
+ ("weekday", "expected"),
[
("Monday", 1),
(WeekDay.MONDAY, 1),
@@ -61,7 +61,7 @@ class TestWeekDay:
WeekDay.convert(invalid)
@pytest.mark.parametrize(
- "weekday, expected",
+ ("weekday", "expected"),
[
("Monday", {WeekDay.MONDAY}),
(WeekDay.MONDAY, {WeekDay.MONDAY}),
