menghot commented on PR #57815: URL: https://github.com/apache/airflow/pull/57815#issuecomment-3506417304
> > > The is the kind of issues we had when @potiuk and I worked on upgrading to fab5. It looks similar. @potiuk if you have some time to look at these tests, that'd be awesome > > > > > > @potiuk @vincbeck The unit tests is fixed . I removed "get_application_builder" from providers/fab/src/airflow/providers/fab/auth_manager/api_fastapi/routes/login.py, which may be causing the app builder to initialize twice. Please correct me if I'm wrong, as this is my first PR to Airflow and also my first PR on GitHub. Thank you. > > Nice !!! You have some super powers man, I'd love to see you contribute more to Airflow :D I spent hours trying to fix them with no success. Really nice job! I am approving, another test is failing though but it looks unrelated to your PR, probably an issue on main. I am no longer available for the next 2 weeks but I am sure others will carry on and review your PR :) Again, very good job! Thank you. It's my honor. I hope I can contribute more to Airflow , My Arflow development env is ready ^_^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
