feluelle commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports. Depends on [AIRFLOW-6010] URL: https://github.com/apache/airflow/pull/6596#discussion_r350253086
########## File path: airflow/executors/local_executor.py ########## @@ -46,37 +46,37 @@ from multiprocessing import Manager, Process, Queue as MultiprocessingQueue from multiprocessing.managers import SyncManager from queue import Empty, Queue # pylint: disable=unused-import # noqa: F401 -from typing import Any, List, Optional, Tuple, Union # pylint: disable=unused-import +from typing import Any, List, Optional, Tuple, Union # pylint: disable=unused-import # noqa: F401 from airflow import AirflowException from airflow.executors.base_executor import PARALLELISM, BaseExecutor -from airflow.executors.executor_type_aliases import CommandType, ExecutorKeyType +from airflow.executors.executor_types import TaskInstanceState # pylint: disable=unused-import # noqa: F401 +from airflow.executors.executor_types import CommandType, TaskInstanceKey from airflow.utils.log.logging_mixin import LoggingMixin from airflow.utils.state import State class LocalWorkerBase(Process, LoggingMixin): - """LocalWorker Process implementation to run airflow commands. Executes the given - command and puts the result into a result queue when done, terminating execution.""" + """ + LocalWorker Process implementation to run airflow commands. Executes the given + command and puts the result into a result queue when done, terminating execution. - def __init__(self, result_queue: 'MultiprocessingQueue[Tuple[ExecutorKeyType, str]]'): - """ - :param result_queue: the queue to store result states tuples (key, State) - :type result_queue: MultiprocessingQueue - """ + :param result_queue: the queue to store result state + Review comment: empty line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
