This is an automated email from the ASF dual-hosted git repository.
ephraimanierobi pushed a commit to branch v3-1-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v3-1-test by this push:
new 88428636c0e [v3-1-test] Enable PT006 rule to dev (#57834) (#57890)
88428636c0e is described below
commit 88428636c0e0d1f809a91002518a8549a3209ee0
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Mon Nov 10 13:30:14 2025 +0100
[v3-1-test] Enable PT006 rule to dev (#57834) (#57890)
(cherry picked from commit 39a740427cf579362fc38335587b237f21b206b0)
Signed-off-by: Anusha Kovi <[email protected]>
Co-authored-by: Anusha Kovi <[email protected]>
Co-authored-by: Kalyan R <[email protected]>
---
dev/breeze/tests/test_cache.py | 2 +-
dev/breeze/tests/test_docker_command_utils.py | 2 +-
dev/breeze/tests/test_exclude_from_matrix.py | 2 +-
dev/breeze/tests/test_general_utils.py | 2 +-
dev/breeze/tests/test_packages.py | 16 ++++++------
dev/breeze/tests/test_provider_documentation.py | 27 ++++++++++++-------
dev/breeze/tests/test_publish_docs_to_s3.py | 4 +--
.../tests/test_pytest_args_for_test_types.py | 6 ++---
dev/breeze/tests/test_selective_checks.py | 30 +++++++++++-----------
dev/breeze/tests/test_shell_params.py | 2 +-
dev/breeze/tests/test_use_airflow_version.py | 2 +-
dev/breeze/tests/test_versions.py | 3 ++-
12 files changed, 54 insertions(+), 44 deletions(-)
diff --git a/dev/breeze/tests/test_cache.py b/dev/breeze/tests/test_cache.py
index f3eb511e517..45f43f598a2 100644
--- a/dev/breeze/tests/test_cache.py
+++ b/dev/breeze/tests/test_cache.py
@@ -32,7 +32,7 @@ AIRFLOW_SOURCES = Path(__file__).parents[3].resolve()
@pytest.mark.parametrize(
- "parameter, value, result, exception",
+ ("parameter", "value", "result", "exception"),
[
("backend", "mysql", (True, ["sqlite", "mysql", "postgres", "none"]),
None),
("backend", "xxx", (False, ["sqlite", "mysql", "postgres", "none"]),
None),
diff --git a/dev/breeze/tests/test_docker_command_utils.py
b/dev/breeze/tests/test_docker_command_utils.py
index 37ecf0ee6f7..5142a751324 100644
--- a/dev/breeze/tests/test_docker_command_utils.py
+++ b/dev/breeze/tests/test_docker_command_utils.py
@@ -222,7 +222,7 @@ def _fake_ctx_output(*names: str) -> str:
@pytest.mark.parametrize(
- "context_output, selected_context, console_output",
+ ("context_output", "selected_context", "console_output"),
[
(
_fake_ctx_output("default"),
diff --git a/dev/breeze/tests/test_exclude_from_matrix.py
b/dev/breeze/tests/test_exclude_from_matrix.py
index d5721fc949a..0a1c5e75e88 100644
--- a/dev/breeze/tests/test_exclude_from_matrix.py
+++ b/dev/breeze/tests/test_exclude_from_matrix.py
@@ -22,7 +22,7 @@ from airflow_breeze.utils.exclude_from_matrix import
excluded_combos, representa
@pytest.mark.parametrize(
- "list_1, list_2, expected_representative_list",
+ ("list_1", "list_2", "expected_representative_list"),
[
(["3.8", "3.9"], ["1", "2"], [("3.8", "1"), ("3.9", "2")]),
(["3.8", "3.9"], ["1", "2", "3"], [("3.8", "1"), ("3.9", "2"), ("3.8",
"3")]),
diff --git a/dev/breeze/tests/test_general_utils.py
b/dev/breeze/tests/test_general_utils.py
index 719f4e395e9..5302d52f8a6 100644
--- a/dev/breeze/tests/test_general_utils.py
+++ b/dev/breeze/tests/test_general_utils.py
@@ -22,7 +22,7 @@ from airflow_breeze.utils.packages import
get_long_package_names
@pytest.mark.parametrize(
- "short_form_providers, expected",
+ ("short_form_providers", "expected"),
[
pytest.param(
("awesome", "foo.bar"),
diff --git a/dev/breeze/tests/test_packages.py
b/dev/breeze/tests/test_packages.py
index 04711c4b83d..7dc077c4404 100644
--- a/dev/breeze/tests/test_packages.py
+++ b/dev/breeze/tests/test_packages.py
@@ -123,7 +123,7 @@ def test_get_suspended_provider_folders():
@pytest.mark.parametrize(
- "short_packages, filters, long_packages",
+ ("short_packages", "filters", "long_packages"),
[
(("amazon",), (), ("apache-airflow-providers-amazon",)),
(("apache.hdfs",), (), ("apache-airflow-providers-apache-hdfs",)),
@@ -151,7 +151,7 @@ def test_find_matching_long_package_name_bad_filter():
@pytest.mark.parametrize(
- "provider_id, pip_package_name",
+ ("provider_id", "pip_package_name"),
[
("asana", "apache-airflow-providers-asana"),
("apache.hdfs", "apache-airflow-providers-apache-hdfs"),
@@ -162,7 +162,7 @@ def test_get_pip_package_name(provider_id: str,
pip_package_name: str):
@pytest.mark.parametrize(
- "provider_id, expected_package_name",
+ ("provider_id", "expected_package_name"),
[
("asana", "apache_airflow_providers_asana"),
("apache.hdfs", "apache_airflow_providers_apache_hdfs"),
@@ -173,7 +173,7 @@ def test_get_dist_package_name_prefix(provider_id: str,
expected_package_name: s
@pytest.mark.parametrize(
- "requirement_string, expected",
+ ("requirement_string", "expected"),
[
pytest.param("apache-airflow", ("apache-airflow", ""),
id="no-version-specifier"),
pytest.param(
@@ -213,7 +213,7 @@ def test_parse_pip_requirements_parse(requirement_string:
str, expected: tuple[s
@pytest.mark.parametrize(
- "requirements, markdown, table",
+ ("requirements", "markdown", "table"),
[
(
["apache-airflow>2.5.0", "apache-airflow-providers-http"],
@@ -249,7 +249,7 @@ def test_validate_provider_info_with_schema():
@pytest.mark.parametrize(
- "provider_id, min_version",
+ ("provider_id", "min_version"),
[
("amazon", "2.10.0"),
("fab", "3.0.2"),
@@ -343,7 +343,7 @@ def _check_dependencies_modified_properly(
@pytest.mark.parametrize(
- "provider_id, version_suffix, floored_version_suffix",
+ ("provider_id", "version_suffix", "floored_version_suffix"),
[
("google", ".dev0", ".dev0"),
("google", ".dev1", ".dev0"),
@@ -397,7 +397,7 @@ AIRFLOWCTL_INIT_PY = AIRFLOW_ROOT_PATH / "airflow-ctl" /
"src" / "airflowctl" /
@pytest.mark.parametrize(
- "distributions, init_file_path, version_suffix, floored_version_suffix",
+ ("distributions", "init_file_path", "version_suffix",
"floored_version_suffix"),
[
(("airflow-core", "."), AIRFLOW_CORE_INIT_PY, ".dev0", ".dev0"),
(("airflow-core", "."), AIRFLOW_CORE_INIT_PY, ".dev1+testversion34",
".dev0"),
diff --git a/dev/breeze/tests/test_provider_documentation.py
b/dev/breeze/tests/test_provider_documentation.py
index 7502f449fd9..11b7221b46a 100644
--- a/dev/breeze/tests/test_provider_documentation.py
+++ b/dev/breeze/tests/test_provider_documentation.py
@@ -89,7 +89,7 @@ def test_find_insertion_index_insert_new_changelog():
@pytest.mark.parametrize(
- "version, provider_id, suffix, tag",
+ ("version", "provider_id", "suffix", "tag"),
[
("1.0.1", "asana", "", "providers-asana/1.0.1"),
("1.0.1", "asana", "rc1", "providers-asana/1.0.1rc1"),
@@ -101,7 +101,7 @@ def test_get_version_tag(version: str, provider_id: str,
suffix: str, tag: str):
@pytest.mark.parametrize(
- "folder_paths, from_commit, to_commit, git_command",
+ ("folder_paths", "from_commit", "to_commit", "git_command"),
[
(None, None, None, ["git", "log", "--pretty=format:%H %h %cd %s",
"--date=short", "--", "."]),
(
@@ -145,7 +145,7 @@ def test_get_git_log_command_wrong():
@pytest.mark.parametrize(
- "line, version, change",
+ ("line", "version", "change"),
[
(
"LONG_HASH_123144 SHORT_HASH 2023-01-01 Description `with` no pr",
@@ -180,7 +180,7 @@ def test_get_change_from_line(line: str, version: str,
change: Change):
@pytest.mark.parametrize(
- "input, output, markdown, changes_len",
+ ("input", "output", "markdown", "changes_len"),
[
(
"""
@@ -251,8 +251,17 @@ def generate_short_hash():
@pytest.mark.parametrize(
- "descriptions, with_breaking_changes, maybe_with_new_features,"
- "breaking_count, feature_count, bugfix_count, other_count, misc_count,
type_of_change",
+ (
+ "descriptions",
+ "with_breaking_changes",
+ "maybe_with_new_features",
+ "breaking_count",
+ "feature_count",
+ "bugfix_count",
+ "other_count",
+ "misc_count",
+ "type_of_change",
+ ),
[
(["Added feature x"], True, True, 0, 1, 0, 0, 0,
[TypeOfChange.FEATURE]),
(["Added feature x"], False, True, 0, 1, 0, 0, 0,
[TypeOfChange.FEATURE]),
@@ -307,7 +316,7 @@ def test_classify_changes_automatically(
@pytest.mark.parametrize(
- "initial_version, bump_index, expected_version",
+ ("initial_version", "bump_index", "expected_version"),
[
("4.2.1", VERSION_MAJOR_INDEX, "5.0.0"),
("3.5.9", VERSION_MINOR_INDEX, "3.6.0"),
@@ -322,7 +331,7 @@ def
test_version_bump_for_provider_documentation(initial_version, bump_index, ex
@pytest.mark.parametrize(
- "changes, expected",
+ ("changes", "expected"),
[
pytest.param([TypeOfChange.SKIP], TypeOfChange.SKIP, id="only-skip"),
pytest.param([TypeOfChange.DOCUMENTATION], TypeOfChange.DOCUMENTATION,
id="only-doc"),
@@ -395,7 +404,7 @@ def test_get_most_impactful_change(changes, expected):
@pytest.mark.parametrize(
- "provider_id, changed_files, expected",
+ ("provider_id", "changed_files", "expected"),
[
pytest.param("slack", ["providers/slack/docs/slack.rst"],
"documentation", id="only_docs"),
pytest.param(
diff --git a/dev/breeze/tests/test_publish_docs_to_s3.py
b/dev/breeze/tests/test_publish_docs_to_s3.py
index f3193e4f989..0e9fad9a660 100644
--- a/dev/breeze/tests/test_publish_docs_to_s3.py
+++ b/dev/breeze/tests/test_publish_docs_to_s3.py
@@ -87,7 +87,7 @@ class TestPublishDocsToS3:
self.publish_docs_to_s3.get_all_eligible_docs
@pytest.mark.parametrize(
- "all_eligible_docs, doc_exists, overwrite,
expected_source_dest_mapping",
+ ("all_eligible_docs", "doc_exists", "overwrite",
"expected_source_dest_mapping"),
[
(
["apache-airflow-providers-amazon",
"apache-airflow-providers-google", "apache-airflow"],
@@ -194,7 +194,7 @@ class TestPublishDocsToS3:
assert self.publish_docs_to_s3.source_dest_mapping ==
expected_source_dest_mapping
@pytest.mark.parametrize(
- "all_eligible_docs, doc_exists, overwrite,
expected_source_dest_mapping",
+ ("all_eligible_docs", "doc_exists", "overwrite",
"expected_source_dest_mapping"),
[
(
["apache-airflow-providers-amazon",
"apache-airflow-providers-google", "apache-airflow"],
diff --git a/dev/breeze/tests/test_pytest_args_for_test_types.py
b/dev/breeze/tests/test_pytest_args_for_test_types.py
index 80b818c3a31..d3b8abd0012 100644
--- a/dev/breeze/tests/test_pytest_args_for_test_types.py
+++ b/dev/breeze/tests/test_pytest_args_for_test_types.py
@@ -39,7 +39,7 @@ def _find_all_integration_folders() -> list[str]:
@pytest.mark.parametrize(
- "test_group, test_type, pytest_args",
+ ("test_group", "test_type", "pytest_args"),
[
# Those list needs to be updated every time we add a new directory to
airflow-core/tests/ folder
(
@@ -211,7 +211,7 @@ def test_pytest_args_for_missing_provider():
@pytest.mark.parametrize(
- "test_group, parallel_test_types, folders",
+ ("test_group", "parallel_test_types", "folders"),
[
(
GroupOfTests.CORE,
@@ -344,7 +344,7 @@ def test_folders_for_parallel_test_types(
@pytest.mark.parametrize(
- "test_group, parallel_test_types",
+ ("test_group", "parallel_test_types"),
[
(
GroupOfTests.CORE,
diff --git a/dev/breeze/tests/test_selective_checks.py
b/dev/breeze/tests/test_selective_checks.py
index 112f030f7a4..54b2c049bf1 100644
--- a/dev/breeze/tests/test_selective_checks.py
+++ b/dev/breeze/tests/test_selective_checks.py
@@ -212,7 +212,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str,
str], stderr: str):
@pytest.mark.parametrize(
- "files, expected_outputs,",
+ ("files", "expected_outputs"),
[
(
pytest.param(
@@ -1162,7 +1162,7 @@ def test_expected_output_pull_request_main(
reason="This test should not run if .git folder is missing (for example by
default in breeze container)",
)
@pytest.mark.parametrize(
- "files, commit_ref, expected_outputs",
+ ("files", "commit_ref", "expected_outputs"),
[
(
pytest.param(
@@ -1227,7 +1227,7 @@ def test_excluded_providers():
@pytest.mark.parametrize(
- "files, expected_outputs",
+ ("files", "expected_outputs"),
[
(
pytest.param(
@@ -1278,7 +1278,7 @@ def test_full_test_needed_when_scripts_changes(files:
tuple[str, ...], expected_
@pytest.mark.parametrize(
- "files, pr_labels, default_branch, expected_outputs,",
+ ("files", "pr_labels", "default_branch", "expected_outputs"),
[
(
pytest.param(
@@ -1573,7 +1573,7 @@ def test_expected_output_full_tests_needed(
@pytest.mark.parametrize(
- "files, expected_outputs,",
+ ("files", "expected_outputs"),
[
pytest.param(
("INTHEWILD.md",),
@@ -1691,7 +1691,7 @@ def test_expected_output_pull_request_v2_7(
@pytest.mark.parametrize(
- "files, pr_labels, default_branch, expected_outputs,",
+ ("files", "pr_labels", "default_branch", "expected_outputs"),
[
pytest.param(
("INTHEWILD.md",),
@@ -1778,7 +1778,7 @@ def test_expected_output_push(
@pytest.mark.parametrize(
- "files, expected_outputs,",
+ ("files", "expected_outputs"),
[
pytest.param(
("INTHEWILD.md",),
@@ -2047,7 +2047,7 @@ def
test_files_provided_trigger_full_build_for_any_event_type(github_event):
@pytest.mark.parametrize(
- "files, expected_outputs, pr_labels, commit_ref",
+ ("files", "expected_outputs", "pr_labels", "commit_ref"),
[
pytest.param(
("airflow-core/src/airflow/models/dag.py",),
@@ -2095,7 +2095,7 @@ def test_upgrade_to_newer_dependencies(
@pytest.mark.parametrize(
- "files, expected_outputs,",
+ ("files", "expected_outputs"),
[
pytest.param(
("providers/google/docs/some_file.rst",),
@@ -2208,7 +2208,7 @@ def test_docs_filter(files: tuple[str, ...],
expected_outputs: dict[str, str]):
@pytest.mark.parametrize(
- "files, expected_outputs,",
+ ("files", "expected_outputs"),
[
pytest.param(
("helm-tests/tests/helm_tests/random_helm_test.py",),
@@ -2233,7 +2233,7 @@ def test_helm_tests_trigger_ci_build(files: tuple[str,
...], expected_outputs: d
@pytest.mark.parametrize(
- "files, expected_outputs,",
+ ("files", "expected_outputs"),
[
pytest.param(
("providers/amazon/provider.yaml",),
@@ -2287,7 +2287,7 @@ def
test_provider_yaml_or_pyproject_toml_changes_trigger_ci_build(
@pytest.mark.parametrize(
- "files, has_migrations",
+ ("files", "has_migrations"),
[
pytest.param(
("airflow-core/src/airflow/test.py",),
@@ -2314,7 +2314,7 @@ def test_has_migrations(files: tuple[str, ...],
has_migrations: bool):
@pytest.mark.parametrize(
- "labels, expected_outputs,",
+ ("labels", "expected_outputs"),
[
pytest.param(
(),
@@ -2348,7 +2348,7 @@ def test_provider_compatibility_checks(labels: tuple[str,
...], expected_outputs
@pytest.mark.parametrize(
- "files, expected_outputs, default_branch, pr_labels",
+ ("files", "expected_outputs", "default_branch", "pr_labels"),
[
pytest.param(
("README.md",),
@@ -2558,7 +2558,7 @@ def test_runner_type_schedule(mock_get):
@pytest.mark.parametrize(
- "integration, runner_type, expected_result",
+ ("integration", "runner_type", "expected_result"),
[
pytest.param(
"mssql",
diff --git a/dev/breeze/tests/test_shell_params.py
b/dev/breeze/tests/test_shell_params.py
index a08aca2c368..ffc0dc56e5b 100644
--- a/dev/breeze/tests/test_shell_params.py
+++ b/dev/breeze/tests/test_shell_params.py
@@ -29,7 +29,7 @@ console = Console(width=400, color_system="standard")
@pytest.mark.parametrize(
- "env_vars, kwargs, expected_vars",
+ ("env_vars", "kwargs", "expected_vars"),
[
pytest.param(
{},
diff --git a/dev/breeze/tests/test_use_airflow_version.py
b/dev/breeze/tests/test_use_airflow_version.py
index 4e7f2a9ed75..3a8c31d9060 100644
--- a/dev/breeze/tests/test_use_airflow_version.py
+++ b/dev/breeze/tests/test_use_airflow_version.py
@@ -24,7 +24,7 @@ from airflow_breeze.global_constants import
GITHUB_REPO_BRANCH_PATTERN, PR_NUMBE
@pytest.mark.parametrize(
- "value, should_match_pr, should_match_repo",
+ ("value", "should_match_pr", "should_match_repo"),
[
pytest.param("57219", True, False, id="pr_number"),
pytest.param("12345", True, False, id="another_pr_number"),
diff --git a/dev/breeze/tests/test_versions.py
b/dev/breeze/tests/test_versions.py
index 8ecf1118fe1..67217e903b5 100644
--- a/dev/breeze/tests/test_versions.py
+++ b/dev/breeze/tests/test_versions.py
@@ -22,7 +22,8 @@ from airflow_breeze.utils.versions import
strip_leading_zeros_from_version
@pytest.mark.parametrize(
- "version,stripped_version", [("3.4.0", "3.4.0"), ("13.04.05", "13.4.5"),
("0003.00004.000005", "3.4.5")]
+ ("version", "stripped_version"),
+ [("3.4.0", "3.4.0"), ("13.04.05", "13.4.5"), ("0003.00004.000005",
"3.4.5")],
)
def test_strip_leading_versions(version: str, stripped_version):
assert stripped_version == strip_leading_zeros_from_version(version)
