msb217 commented on a change in pull request #6652: [AIRFLOW-5548] [AIRFLOW-5550] REST API enhancement - dag info, task … URL: https://github.com/apache/airflow/pull/6652#discussion_r350283435
########## File path: airflow/api/common/experimental/get_dags.py ########## @@ -0,0 +1,29 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Dags APIs..""" +import typing + +from airflow.api.common.experimental import check_and_get_dags + + +def get_dags() -> typing.List[str]: + """Return a list of ids of the dags located within the dagbag.""" + dags = check_and_get_dags() + + return dags Review comment: I added the additional function/file for the sake of consistency in the project structure. Each API definition in `endpoints.py` calls some function in a file in `api/commons/experimental`. I agree that it's not necessary and I can get rid of it. I think it may be beneficial to refactor `api/commons/experimental`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
