amoghrajesh opened a new pull request, #58188:
URL: https://github.com/apache/airflow/pull/58188
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Through this PR I intend to refactor `AirflowConfigParser.validate()` to use
a pluggable validator pattern, enabling subclasses to customize which
validators run during configuration validation.
### Why am I doing this?
This prepares for moving the configuration parser to a shared library (as
work has been started on https://github.com/apache/airflow/pull/57744). The
shared parser will be used by both airflow-core and task-sdk, but each
distribution could need different validators, example:
- Core needs: SQLite version checks, Postgres connection upgrades, enum
validation, deprecated value handling
- SDK needs: None of the above (no database validators, no Core-specific
enums at all)
Without this refactoring, SDK would inherit all Core validators, if those
move to shared. If they stay in core, then there would be unnecessary
duplication of code which can potentially become a maintenance burden.
### How this change helps:
- Subclasses can customize validation by overriding `_validators`
- Each validator is a separate method, easier to test and maintain
- Backward compatible: Same validators run, just organized differently
Future Benefits:
- Easier migration to shared: When moving to shared parser, SDK can override
`_validators` to exclude core specific validators
- No code duplication: Validators of core stay in core, SDK inherits empty
list from shared and can override as needed
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
