ashb commented on a change in pull request #6643: [AIRFLOW-6040] Fix
KubernetesJobWatcher Read time out error
URL: https://github.com/apache/airflow/pull/6643#discussion_r350323618
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -265,12 +265,12 @@ def run(self):
def _run(self, kube_client, resource_version, worker_uuid, kube_config):
self.log.info(
- 'Event: and now my watch begins starting at resource_version: %s',
- resource_version
- )
+ 'Event: and now my watch begins starting at resource_version: %s, '
+ 'worker_uuid: %s', resource_version, worker_uuid)
watcher = watch.Watch()
- kwargs = {'label_selector': 'airflow-worker={}'.format(worker_uuid)}
+ kwargs = {'label_selector': 'airflow-worker={}'.format(worker_uuid),
+ 'timeout_seconds': 50}
Review comment:
Wait, we already use the config option two lines down.
Someone on slack mentioned that this won't work but I don't see why from the
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
