ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle
Executors class to avoid cyclic imports. Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#discussion_r350326731
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -66,7 +67,7 @@ class DagFileProcessor(AbstractDagFileProcessor,
LoggingMixin):
:param dag_id_white_list: If specified, only look at these DAG ID's
:type dag_id_white_list: list[unicode]
:param zombies: zombie task instances to kill
- :type zombies: list[airflow.utils.dag_processing.SimpleTaskInstance]
+ :type zombies: list[airflow.executors.executor_types.SimpleTaskInstance]
Review comment:
Types for doc comments don't respect/use imports - they create links based
on the package name only
(i.e. mypy respects imports, sphinx doesn't and needs full package names to
create a link when rendering.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
