kaxil commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r350331737
########## File path: airflow/serialization/base_serialization.py ########## @@ -22,17 +22,18 @@ import datetime import enum import logging -from typing import TYPE_CHECKING, Dict, Optional, Union +from inspect import Parameter +from typing import Dict, Optional, Set, Union import pendulum from dateutil import relativedelta -import airflow +from airflow import DAG Review comment: Are we not using `from airflow.models import DAG` to remove cyclic import? Now we would have 2 version in the core as well. `from airflow import DAG` and `from airflow.models import DAG` in the core codebase ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
