jscheffl commented on PR #58208: URL: https://github.com/apache/airflow/pull/58208#issuecomment-3518679851
> FYI. fetch_task_instances is only used in the `get_task_instances` API - so this is **really** a question if we want get_task_instances to return task instances in random order essentially - without sorting specified. @pierrejeambrun -> WDYT? Ah, okay, I thought it is the implementation that is used roughly 1000 times in business logic all over the place to get tasks. Then it would have a massive impact of performance if results are _always_ sorted. I don't think we need to ensure a deterministic order. Except is defined in interface contract. Or making sorting an optional param as said. If the function is only used in the API why is the select then in the model classes and not in the API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
