kaxil commented on a change in pull request #6564: [AIRFLOW-5911] Simplify 
lineage API and improve robustness
URL: https://github.com/apache/airflow/pull/6564#discussion_r350387664
 
 

 ##########
 File path: airflow/operators/papermill_operator.py
 ##########
 @@ -16,18 +16,22 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from typing import Dict
+from typing import Dict, Optional
 
+import attr
 import papermill as pm
 
-from airflow.lineage.datasets import DataSet
+from airflow.lineage.entities import File
 from airflow.models import BaseOperator
 from airflow.utils.decorators import apply_defaults
 
 
-class NoteBook(DataSet):
-    type_name = "jupyter_notebook"
-    attributes = ['location', 'parameters']
[email protected](auto_attribs=True)
+class NoteBook(File):
+    type_hint: Optional[str] = "jupyter_notebook"
 
 Review comment:
   Let's add description and docstring for this class in the subsequent PRs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to