amoghrajesh commented on code in PR #58147:
URL: https://github.com/apache/airflow/pull/58147#discussion_r2519440659
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1495,6 +1496,44 @@ def request(self, *args, **kwargs):
# Bypass the tenacity retries!
return super().request.__wrapped__(self, *args, **kwargs) # type:
ignore[attr-defined]
+ def _check_subprocess_exit(
+ self, raise_on_timeout: bool = False, expect_signal: None | int = None
+ ) -> int | None:
+ # In process has no subprocess, so we don't need to poll anything.
This is called from
Review Comment:
```suggestion
# If a process has no subprocess, so we don't need to poll anything.
This is called from
```
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1547,16 +1586,20 @@ def start( # type: ignore[override]
start_date=start_date,
state=TaskInstanceState.RUNNING,
)
- context = ti.get_template_context()
- log = structlog.get_logger(logger_name="task")
- state, msg, error = run(ti, context, log)
- finalize(ti, state, context, log, error)
+ # Create a socketpair preemptively, in case the task process runs
VirtualEnv operator or run as
+ # user.
Review Comment:
```suggestion
# Create a socketpair pre-emptively, in case the task process
runs VirtualEnv operator or run_as_user
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
