sunank200 opened a new pull request, #58264:
URL: https://github.com/apache/airflow/pull/58264
Log (dag_id, hash) pairs to help debug flaky test failures.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
The test `test_example_dag_hashes_are_always_consistent` was likely flaky
before, but it's more visible now
[here](https://github.com/apache/airflow/actions/runs/19315183483) The test has
been failing intermittently in CI (particularly in Postgres 17 tests) with hash
mismatches.
Here
- The hash is calculated entirely in Python before storing, so it's not
directly dependent on the Postgres version
- The issue is that the input to the hash can vary between runs
- The test calls `_write_example_dags()` twice, and if the filesystem
returns files in a different order, DAGs may load in a different order
- This can result in different hashes for the same DAG between runs
- The problematic hash `552a27ed3bf3a2fbebfd294db469c25b` has been observed,
but we need to identify which DAG produces it
I have added TODO: Remove this logging once the origin of the flaky test is
identified and fixed
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
