potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r350424929
########## File path: airflow/serialization/base_serialization.py ########## @@ -22,17 +22,18 @@ import datetime import enum import logging -from typing import TYPE_CHECKING, Dict, Optional, Union +from inspect import Parameter +from typing import Dict, Optional, Set, Union import pendulum from dateutil import relativedelta -import airflow +from airflow import DAG Review comment: The change to standardize DAG usage is coming :). I changed it from airflow.models import DAG here. The previous change was not actually working as I wanted. As @ashb pointed out, `from airflow.models import DAG' also runs __init__.py of 'airflow' package, so it would not actually change anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
