hwang-cadent commented on PR #58157: URL: https://github.com/apache/airflow/pull/58157#issuecomment-3528964717
> I think it should it be a separate Hook extending Databricks generic Hook (DatabricksGoogleHook?). It does not seem right to embed gcp-specific parameters in a generic hook? > > WDYT @VladaZakharova ? Thank you for the feedback, @potiuk! You're absolutely right - embedding GCP-specific parameters in the generic `BaseDatabricksHook` is not the right architectural approach. I'm happy to refactor the code to create a new `DatabricksGoogleHook` class. Should I proceed with this refactoring now, or would you prefer to wait for @VladaZakharova's input first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
