dabla opened a new pull request, #58282:
URL: https://github.com/apache/airflow/pull/58282
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
I discovered a bug in the run_trigger method of the TriggerRunner by
accident due to the fact that I added typing to the trigger parameter when
working on [PR #55068](https://github.com/apache/airflow/pull/55068).
There I got the following MyPy from the Airflow CI/CD:
```
airflow-core/src/airflow/jobs/triggerer_job_runner.py:1182: error:
"BaseTrigger" has no attribute "timeout_after" [attr-defined]
if timeout := trigger.timeout_after:
```
First I thought I did a mistake with the typing, but after closer
investigation the typing was correct and so was also the MyPy error. Then I
discovered that the timeout_after attribute was indeed never part of the
BaseTrigger but was part of the workloads.RunTrigger model. So I refactored
the run_trigger method so that beside trigger_id and trigger, it now also has
the optional timeout_after parameter which is passed from the
workloads.RunTrigger model.
I don't know if this has ever lead to any issue at runtime, but I would
certainly lead to an exception is a trigger would be cancelled.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
