feluelle commented on code in PR #58314:
URL: https://github.com/apache/airflow/pull/58314#discussion_r2528224185
##########
airflow-core/src/airflow/ui/src/utils/logs.ts:
##########
@@ -70,5 +72,10 @@ export const parseStreamingLogContent = (
}
}
- return data.content;
+ // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+ if (typeof data === "object" && data !== null) {
Review Comment:
I don't think so. We only want non-null objects.
```
FAIL src/utils/logs.test.ts > parseStreamingLogContent > returns empty
array for null data
AssertionError: expected [ null ] to deeply equal []
- Expected
+ Received
- []
+ [
+ null,
+ ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
