itayweb commented on code in PR #58102:
URL: https://github.com/apache/airflow/pull/58102#discussion_r2529883300
##########
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py:
##########
@@ -261,6 +272,92 @@ def handle_bulk_update(
except HTTPException as e:
results.errors.append({"error": f"{e.detail}", "status_code":
e.status_code})
+ def handle_request_dry_run(self) -> TaskInstanceCollectionResponse:
Review Comment:
Done
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -891,9 +891,26 @@ def bulk_task_instances(
) -> BulkResponse:
"""Bulk update, and delete task instances."""
return BulkTaskInstanceService(
- session=session, request=request, dag_id=dag_id,
dag_run_id=dag_run_id, dag_bag=dag_bag, user=user
+ session=session, request=request, dag_id=dag_id,
dag_run_id=dag_run_id, dag_bag=dag_bag, user=user, commit=True,
Review Comment:
I've removed the duplicate dry run function and used the new parameter
passed (commit) to reuse the existing function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
