potiuk commented on code in PR #58209:
URL: https://github.com/apache/airflow/pull/58209#discussion_r2530098600


##########
airflow-core/src/airflow/api_fastapi/execution_api/app.py:
##########
@@ -218,7 +218,7 @@ def custom_generate_unique_id(route: APIRoute):
     @app.exception_handler(Exception)
     def handle_exceptions(request: Request, exc: Exception):
         logger.exception("Handle died with an error", exc_info=(type(exc), 
exc, exc.__traceback__))
-        content = {"message": "Internal server error"}
+        content = {"message": "Internal server error", "details": str(exc) or 
""}

Review Comment:
   We even write about it in our contribution guides:
   
   
https://github.com/apache/airflow/blob/main/contributing-docs/04_how_to_contribute.rst#issue-reporting-and-resolution-process
   
   > An unusual element of the Apache Airflow project is that you can open a PR 
to fix an issue or make an enhancement, without needing to open an issue first. 
This is intended to make it as easy as possible to contribute to the project.
   
   > If you however feel the need to open an issue (usually a bug or feature 
request) consider starting with a [GitHub 
Discussion](https://github.com/apache/airflow/discussions) instead. In the vast 
majority of cases discussions are better than issues - you should only open 
issues if you are sure you found a bug and have a reproducible case, or when 
you want to raise a feature request that will not require a lot of discussion. 
If you have a very important topic to discuss, start a discussion on the 
[Devlist](https://lists.apache.org/[email protected]) instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to