jroachgolf84 opened a new pull request, #58357:
URL: https://github.com/apache/airflow/pull/58357

   ## Description
   
   Added integration tests for `Variable` operations. There were two stubbed 
tests in `test_variable_operations.py`. These were:
   
   * `test_variable_set`
   * `test_variable_delete`
   
   The pattern implemented in `test_xcom_operations.py` was leveraged as a 
reference for implementing these stubbed tests, especially 
`test_variable_delete`. These tests can be run by pulling down this branch and 
running the command below:
   
   ```
   breeze testing task-sdk-integration-tests 
tests/task_sdk_tests/test_variable_operations.py
   ```
   
   ## Outstanding Issues
   
   When running the `test_variable_operations.py::test_variable_delete` 
function, the following is being output (see below). *This implies that the 
variable is NOT being truly being deleted when `sdk_client.variables.delete` is 
called.*
   
   ```
           # Validate that the Variable has in fact been deleted
           get_response = sdk_client.variables.get("test_variable_key")
       
           assert isinstance(get_response, ErrorResponse)
           AssertionError: assert False
            +  where False = 
isinstance(VariableResponse(key='test_variable_key', 
value='test_variable_value'), ErrorResponse)
   ```
   
   related: 
https://github.com/apache/airflow/issues/58178#issuecomment-3521015783


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to