RoyLee1224 opened a new pull request, #58359:
URL: https://github.com/apache/airflow/pull/58359
## Related
part of #55900
part of #56250 (The hover tooltips disappear about a second after popping
up.)
## Changes
- Refactor `HoverTooltip` and rename it to `BasicTooltip`
- Migrate from `HoverTooltip` to `BasicTooltip` in Calendar tab
- Apply `BasicTooltip` to task instance and runs tooltips in Grid view
## Why
- Chakra UI's Tooltip got some performance issues. The custom `BasicTooltip`
provides similar functionality with better rendering performance
Performance issue Reference:
https://github.com/apache/airflow/pull/51736#issuecomment-2981597364
- Renamed from `HoverTooltip` to `BasicTooltip` to better reflect its
purpose as a performant tooltip component suitable for high-density UI(eg. Grid
view, Calendar tab).
## Screenshots
### Performance (Chakra UI tooltip vs. BasicTooltip)
I've tried with both approaches, Charka UI looks laggy with large amount TIs
https://github.com/user-attachments/assets/8c0924ac-e3f9-461a-b625-4088514679ee
https://github.com/user-attachments/assets/dd343f13-af2c-4c0c-bd9f-ce21302ea460
### Before / After
**Before** (tooltip somehow disappear)
https://github.com/user-attachments/assets/ddc67ccc-6588-41b2-b315-f2ae06429ece
**After**(tooltip last correctly)
https://github.com/user-attachments/assets/542f4257-d0ed-4ff7-b693-d2b050e3fdf8
**Before**
| Before (use default title for run tooltip) | After (consistent tooltip
with TI) |
| :---: | :---: |
| <img
src="https://github.com/user-attachments/assets/a2142cf9-c16c-41bc-82d6-f02ece053ac5";
width="350"> | <img
src="https://github.com/user-attachments/assets/88d571b1-fadc-48d3-9c5e-e3447e2b3438";
width="350"> |
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
