amoghrajesh commented on code in PR #58356:
URL: https://github.com/apache/airflow/pull/58356#discussion_r2532972364


##########
airflow-core/docs/core-concepts/xcoms.rst:
##########
@@ -49,6 +49,8 @@ Many operators will auto-push their results into an XCom key 
called ``return_val
     # Pulls the return_value XCOM from "pushing_task"
     value = task_instance.xcom_pull(task_ids='pushing_task')
 
+The ``return_value`` key is defined as a constant ``XCOM_RETURN_KEY`` in the 
:class:`~airflow.models.xcom.XComModel` class and can be accessed as 
``XCom.XCOM_RETURN_KEY`` or imported from ``airflow.models.xcom``. The old 
``airflow.utils.xcom`` module has been removed, but backward compatibility is 
maintained through deprecation shims.

Review Comment:
   This isn't correct.
   
   We should not recommend usage from `airflow.models.xcom`, it was been moved 
inside `BaseXcom` class in task sdk and that is how it should be consumed. The 
occurrence in models.xcom is only for usage within `XComModel` and should not 
be put forward this way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to